From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932509AbXA1JpN (ORCPT ); Sun, 28 Jan 2007 04:45:13 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932507AbXA1JpN (ORCPT ); Sun, 28 Jan 2007 04:45:13 -0500 Received: from il.qumranet.com ([62.219.232.206]:51270 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932509AbXA1JpL (ORCPT ); Sun, 28 Jan 2007 04:45:11 -0500 Message-ID: <45BC70A5.7030707@qumranet.com> Date: Sun, 28 Jan 2007 11:45:09 +0200 From: Avi Kivity User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: caglar@pardus.org.tr CC: lkml , kvm-devel@lists.sourceforge.net Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints References: <200701260140.47760.caglar@pardus.org.tr> <45BB15F1.6020600@qumranet.com> <200701272328.31532.caglar@pardus.org.tr> In-Reply-To: <200701272328.31532.caglar@pardus.org.tr> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org S.Çağlar Onur wrote: > 27 Oca 2007 Cts tarihinde, Avi Kivity şunları yazmıştı: > >> The patch looks correct, but I don't understand the gcc error message. >> Are we sure this isn't a gcc 4.2 bug? >> >> "g" appears to be equivalent to "rmi", if "i" is impossible, gcc is free >> to use "r" or "m", no? >> > > Accorgind to GCC devs. its not a bug > (http://gcc.gnu.org/bugzilla/show_bug.cgi?id=29808), on comment #5 the > problem described like; > > "g" means "r"+"i" so the register allocator in the -O0 case is selecting "r" > while in the optimize case is selecting "i" > > That's a different bug. The gcc PR has an assembler error message, as expected, whereas the kvm miscompile has a compiler error, which I don't understand. Anyhow, your patch is correct (because selecting "i" is indeed erroneous) so I'll apply it, but I'm worried that there's a gcc bug in there that we ought to report. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] KVM: 'asm' operand has impossible constraints Date: Sun, 28 Jan 2007 11:45:09 +0200 Message-ID: <45BC70A5.7030707@qumranet.com> References: <200701260140.47760.caglar@pardus.org.tr> <45BB15F1.6020600@qumranet.com> <200701272328.31532.caglar@pardus.org.tr> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, lkml To: caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org Return-path: In-Reply-To: <200701272328.31532.caglar-caicS1wCkhO6A22drWdTBw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Uy7Dh2HEn2xhciBPbnVyIHdyb3RlOgo+IDI3IE9jYSAyMDA3IEN0cyB0YXJpaGluZGUsIEF2aSBL aXZpdHkgxZ91bmxhcsSxIHlhem3EscWfdMSxOiAKPiAgIAo+PiBUaGUgcGF0Y2ggbG9va3MgY29y cmVjdCwgYnV0IEkgZG9uJ3QgdW5kZXJzdGFuZCB0aGUgZ2NjIGVycm9yIG1lc3NhZ2UuCj4+IEFy ZSB3ZSBzdXJlIHRoaXMgaXNuJ3QgYSBnY2MgNC4yIGJ1Zz8KPj4KPj4gImciIGFwcGVhcnMgdG8g YmUgZXF1aXZhbGVudCB0byAicm1pIiwgaWYgImkiIGlzIGltcG9zc2libGUsIGdjYyBpcyBmcmVl Cj4+IHRvIHVzZSAiciIgb3IgIm0iLCBubz8KPj4gICAgIAo+Cj4gQWNjb3JnaW5kIHRvIEdDQyBk ZXZzLiBpdHMgbm90IGEgYnVnIAo+IChodHRwOi8vZ2NjLmdudS5vcmcvYnVnemlsbGEvc2hvd19i dWcuY2dpP2lkPTI5ODA4KSwgb24gY29tbWVudCAjNSB0aGUgCj4gcHJvYmxlbSBkZXNjcmliZWQg bGlrZTsKPgo+ICJnIiBtZWFucyAiciIrImkiIHNvIHRoZSByZWdpc3RlciBhbGxvY2F0b3IgaW4g dGhlIC1PMCBjYXNlIGlzIHNlbGVjdGluZyAiciIgCj4gd2hpbGUgaW4gdGhlIG9wdGltaXplIGNh c2UgaXMgc2VsZWN0aW5nICJpIgo+Cj4gICAKClRoYXQncyBhIGRpZmZlcmVudCBidWcuIFRoZSBn Y2MgUFIgaGFzIGFuIGFzc2VtYmxlciBlcnJvciBtZXNzYWdlLCBhcyAKZXhwZWN0ZWQsIHdoZXJl YXMgdGhlIGt2bSBtaXNjb21waWxlIGhhcyBhIGNvbXBpbGVyIGVycm9yLCB3aGljaCBJIGRvbid0 IAp1bmRlcnN0YW5kLgoKQW55aG93LCB5b3VyIHBhdGNoIGlzIGNvcnJlY3QgKGJlY2F1c2Ugc2Vs ZWN0aW5nICJpIiBpcyBpbmRlZWQgCmVycm9uZW91cykgc28gSSdsbCBhcHBseSBpdCwgYnV0IEkn bSB3b3JyaWVkIHRoYXQgdGhlcmUncyBhIGdjYyBidWcgaW4gCnRoZXJlIHRoYXQgd2Ugb3VnaHQg dG8gcmVwb3J0LgoKCi0tIAplcnJvciBjb21waWxpbmcgY29tbWl0dGVlLmM6IHRvbyBtYW55IGFy Z3VtZW50cyB0byBmdW5jdGlvbgoKCi0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KVGFrZSBTdXJ2ZXlzLiBFYXJu IENhc2guIEluZmx1ZW5jZSB0aGUgRnV0dXJlIG9mIElUCkpvaW4gU291cmNlRm9yZ2UubmV0J3Mg VGVjaHNheSBwYW5lbCBhbmQgeW91J2xsIGdldCB0aGUgY2hhbmNlIHRvIHNoYXJlIHlvdXIKb3Bp bmlvbnMgb24gSVQgJiBidXNpbmVzcyB0b3BpY3MgdGhyb3VnaCBicmllZiBzdXJ2ZXlzIC0gYW5k IGVhcm4gY2FzaApodHRwOi8vd3d3LnRlY2hzYXkuY29tL2RlZmF1bHQucGhwP3BhZ2U9am9pbi5w aHAmcD1zb3VyY2Vmb3JnZSZDSUQ9REVWREVWCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmt2bS1kZXZlbCBtYWlsaW5nIGxpc3QKa3ZtLWRldmVsQGxpc3Rz LnNvdXJjZWZvcmdlLm5ldApodHRwczovL2xpc3RzLnNvdXJjZWZvcmdlLm5ldC9saXN0cy9saXN0 aW5mby9rdm0tZGV2ZWwK