All of lore.kernel.org
 help / color / mirror / Atom feed
From: alanc@pipstechnology.co.uk (Alan Clucas)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] DS75
Date: Mon, 29 Jan 2007 11:58:00 +0000	[thread overview]
Message-ID: <45BDE148.7020108@pipstechnology.co.uk> (raw)

We have a DS75 on a custom board, which is attached to a Compulab iGLX 
AMD Geode based board - using the CS5536 and an unmodified scx200_acb 
driver to access the smbus/i2c.

On this board is a DS75. It doesn't identify as the chip correctly with 
the lm75 driver in 2.6.19.2 due to the fact that it seems to return the 
last value read for all of its out of spec commands, rather than doing 
the address cycling which the driver expects for command >8 - e.g. 
address 8 behaves like addresses 4 through 7. (I can provide a debug log 
showing this if needed).

With the following patch it identifies correctly and works as expected.

--- linux-2.6.19.2/drivers/hwmon/lm75.c 2007-01-24 16:03:42.000000000 +0000
+++ linux/drivers/hwmon/lm75.c  2007-01-29 11:41:45.000000000 +0000
@@ -181,13 +181,6 @@
                 /* Unused bits */
                 if (conf & 0xe0)
                         goto exit_free;
-
-               /* Addresses cycling */
-               for (i = 8; i < 0xff; i += 8)
-                       if (i2c_smbus_read_byte_data(new_client, i + 1) 
!= conf
-                        || i2c_smbus_read_word_data(new_client, i + 2) 
!= hyst
-                        || i2c_smbus_read_word_data(new_client, i + 3) 
!= os)
-                               goto exit_free;
         }

         /* Determine the chip type - only one kind supported! */

The chip has the following markings on its top:

DS75
SO6A5

Does anyone out there have a DS75 which is being identified correctly - 
the patch to change identify in this way went in quite some time ago...
http://lists.lm-sensors.org/pipermail/lm-sensors/2004-July/008335.html

Alan Clucas

-------------- next part --------------
A non-text attachment was scrubbed...
Name: alanc.vcf
Type: text/x-vcard
Size: 562 bytes
Desc: not available
Url : http://lists.lm-sensors.org/pipermail/lm-sensors/attachments/20070129/cc670374/attachment.vcf 

             reply	other threads:[~2007-01-29 11:58 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-29 11:58 Alan Clucas [this message]
2007-02-04 17:43 ` [lm-sensors] DS75 Jean Delvare
2007-02-05 13:12 ` Alan Clucas
2007-02-05 17:20 ` Jean Delvare
2007-02-06 10:19 ` Alan Clucas
2007-02-06 14:45 ` Jean Delvare
2007-02-07 10:14 ` Alan Clucas
2007-02-09  9:39 ` Jean Delvare
2007-02-15 10:47 ` Jean Delvare
2007-02-15 11:01 ` Alan Clucas
2007-02-15 16:28 ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BDE148.7020108@pipstechnology.co.uk \
    --to=alanc@pipstechnology.co.uk \
    --cc=lm-sensors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.