From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@suse.de>
Subject: Re: [PATCH] fix cross compiling ia64 on x86
Date: Tue, 30 Jan 2007 14:49:14 +0100
Message-ID: <45BF4CDA.1090103@suse.de>
References: <20070130122214.GH25482%yamahata@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20070130122214.GH25482%yamahata@valinux.co.jp>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/Makefile
> --- a/xen/include/public/foreign/Makefile	Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/Makefile	Tue Jan 30 16:51:51 2007 +0900
> @@ -14,12 +14,8 @@ clean:
>  	rm -f *.pyc *.o *~
>  
>  check-headers: checker
> -ifeq ($(CROSS_COMPILE),)
>  	./checker > $(XEN_TARGET_ARCH).size
>  	diff -u reference.size $(XEN_TARGET_ARCH).size
> -else
> -	@echo "cross build: skipping check"
> -endif
>  
>  x86_32.h: ../arch-x86/xen-x86_32.h ../arch-x86/xen.h ../xen.h $(scripts)
>  	python mkheader.py $* $@ $(filter %.h,$^)

Ok.

> diff -r 5bb084098493 -r 94c3db4748b2 xen/include/public/foreign/mkchecker.py
> --- a/xen/include/public/foreign/mkchecker.py	Mon Jan 29 13:22:21 2007 +0000
> +++ b/xen/include/public/foreign/mkchecker.py	Tue Jan 30 16:51:51 2007 +0900
> @@ -38,10 +38,7 @@ for struct in structs:
>  for struct in structs:
>      f.write('\tprintf("%%-20s |", "%s");\n' % struct);
>      for a in archs:
> -        if a == arch:
> -            s = struct; # native
> -        else:
> -            s = struct + "_" + a;
> +        s = struct + "_" + a;
>          f.write('#ifdef %s_has_no_%s\n' % (a, struct));
>          f.write('\tprintf("%8s", "-");\n');
>          f.write("#else\n");

No.  I intentionally use the native version here (struct foo instead of
struct foo_arch) to catch possible inconsistencies.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>