All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerd Hoffmann <kraxel@suse.de>
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
Subject: Re: [PATCH] new domain builder fix to boot domU on IA64.
Date: Tue, 30 Jan 2007 15:06:36 +0100	[thread overview]
Message-ID: <45BF50EC.4020300@suse.de> (raw)
In-Reply-To: <20070130122631.GI25482%yamahata@valinux.co.jp>

> +static int arch_setup_middle(struct xc_dom_image *dom)
> +{
>      DECLARE_DOMCTL;
>      int rc;
>  
> @@ -268,16 +280,35 @@ static int arch_setup_early(struct xc_do
>      domctl.cmd = XEN_DOMCTL_arch_setup;
>      domctl.domain = dom->guest_domid;
>      domctl.u.arch_setup.flags = 0;
> +
> +    /* dom->start_info_pfn should be initialized by alloc_magic_pages().
> +     * However it is called later. So we initialize here.
> +     */
> +    dom->start_info_pfn = dom->total_pages - 3;

Is it an option to call arch_setup_middle as one of the first things in
xc_dom_boot_image()?  That would avoid the start_info_pfn trickery ...

The only thing which happens between the current and the suggested place
is that domU pages are mapped and data is copyed to them.  No other
hypercalls.

If that works out we might consider giving some more desciptive names to
the arch hooks, such as "arch_setup_{meminit,bootearly,bootlate}" or so.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>

  reply	other threads:[~2007-01-30 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30 12:26 [PATCH] new domain builder fix to boot domU on IA64 Isaku Yamahata
2007-01-30 14:06 ` Gerd Hoffmann [this message]
2007-01-31  2:56   ` Isaku Yamahata
2007-01-31 11:58     ` Gerd Hoffmann
2007-02-01  2:57       ` [PATCH] new domain builder setup hook clean up (was Re: [PATCH] new domain builder fix to boot domU on IA64.) Isaku Yamahata
2007-02-01  7:59         ` Gerd Hoffmann
2007-02-01 11:40           ` Isaku Yamahata

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45BF50EC.4020300@suse.de \
    --to=kraxel@suse.de \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    --cc=yamahata@valinux.co.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.