From: Jeff Garzik <jgarzik@pobox.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, m.kozlowski@tuxland.pl,
Andrew Morton <akpm@osdl.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: buggy IFB driver change
Date: Tue, 30 Jan 2007 16:52:27 -0500 [thread overview]
Message-ID: <45BFBE1B.2040508@pobox.com> (raw)
In-Reply-To: <20070130.131246.71091370.davem@davemloft.net>
David Miller wrote:
> Jeff, please revert: 0c0b3ae68ec93b1db5c637d294647d1cca0df763
>
> It's wrong. We had a lengthy analysis of this piece of code
> several months ago, and it is correct.
>
> Consider, if we run the loop and we get an error
> the following happens:
>
> 1) attempt of ifb_init_one(i) fails, therefore we should
> not try to "ifb_free_one()" on "i" since it failed
> 2) the loop iteration first increments "i", then it
> check for error
>
> Therefore we must decrement "i" twice before the first
> free during the cleanup. One to "undo" the for() loop
> increment, and one to "skip" the ifb_init_one() case which
> failed.
>
> commit 0c0b3ae68ec93b1db5c637d294647d1cca0df763
> Author: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Andrew and I both missed that thread, sorry.
I'm about to crash, can you or Linus handle the correction?
Jeff
next prev parent reply other threads:[~2007-01-30 21:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 21:12 buggy IFB driver change David Miller
2007-01-30 21:52 ` Jeff Garzik [this message]
2007-01-30 22:12 ` David Miller
2007-01-31 0:24 ` Joe Perches
2007-01-30 22:13 ` Linus Torvalds
2007-01-30 22:21 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45BFBE1B.2040508@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.