From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932422AbXAaJHH (ORCPT ); Wed, 31 Jan 2007 04:07:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932437AbXAaJHG (ORCPT ); Wed, 31 Jan 2007 04:07:06 -0500 Received: from il.qumranet.com ([62.219.232.206]:51911 "EHLO il.qumranet.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932422AbXAaJHF (ORCPT ); Wed, 31 Jan 2007 04:07:05 -0500 Message-ID: <45C05C35.9040107@qumranet.com> Date: Wed, 31 Jan 2007 11:07:01 +0200 From: Avi Kivity User-Agent: Thunderbird 1.5.0.9 (X11/20061219) MIME-Version: 1.0 To: "Rafael J. Wysocki" CC: nigel@nigel.suspend2.net, kvm-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, akpm@osdl.org, mingo@elte.hu Subject: Re: [PATCH 5/5] KVM: Host suspend/resume support References: <45BF5B96.1070007@qumranet.com> <20070130145717.00D1BA0014@il.qumranet.com> <1170192049.4308.16.camel@nigel.suspend2.net> <200701302319.10369.rjw@sisk.pl> In-Reply-To: <200701302319.10369.rjw@sisk.pl> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Rafael J. Wysocki wrote: > On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote: > >> Hi. >> >> On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote: >> >>> Add the necessary callbacks to suspend and resume a host running kvm. This >>> is just a repeat of the cpu hotplug/unplug work. >>> >>> Signed-off-by: Avi Kivity >>> >> Maybe it's just a lack of understanding, but I'm wondering if this patch >> is necessary - we already hot-unplug secondary cpus prior to suspending >> devices. >> > > The on_each_cpu() in the patch really means on_this_cpu(). > Not with the reoredering patches that are in -mm, though. With these patches, > the nonboot CPUs are disabled after "regular" devices. > After that, it means on_each_cpu() again, and the hotplug patch becomes unnecessary (except to support hotplug, of course). Assuming I understand things correctly, which if not at all certain. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 5/5] KVM: Host suspend/resume support Date: Wed, 31 Jan 2007 11:07:01 +0200 Message-ID: <45C05C35.9040107@qumranet.com> References: <45BF5B96.1070007@qumranet.com> <20070130145717.00D1BA0014@il.qumranet.com> <1170192049.4308.16.camel@nigel.suspend2.net> <200701302319.10369.rjw@sisk.pl> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, akpm-3NddpPZAyC0@public.gmane.org, nigel-MhVfhJ0qHmuWn91e4EydUaxOck334EZe@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Rafael J. Wysocki" Return-path: In-Reply-To: <200701302319.10369.rjw-KKrjLPT3xs0@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rafael J. Wysocki wrote: > On Tuesday, 30 January 2007 22:20, Nigel Cunningham wrote: > >> Hi. >> >> On Tue, 2007-01-30 at 14:57 +0000, Avi Kivity wrote: >> >>> Add the necessary callbacks to suspend and resume a host running kvm. This >>> is just a repeat of the cpu hotplug/unplug work. >>> >>> Signed-off-by: Avi Kivity >>> >> Maybe it's just a lack of understanding, but I'm wondering if this patch >> is necessary - we already hot-unplug secondary cpus prior to suspending >> devices. >> > > The on_each_cpu() in the patch really means on_this_cpu(). > Not with the reoredering patches that are in -mm, though. With these patches, > the nonboot CPUs are disabled after "regular" devices. > After that, it means on_each_cpu() again, and the hotplug patch becomes unnecessary (except to support hotplug, of course). Assuming I understand things correctly, which if not at all certain. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys - and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV