From: Jeff Garzik <jeff@garzik.org>
To: Divy Le Ray <None@chelsio.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
swise@opengridcomputing.com, David Miller <davem@davemloft.net>
Subject: Re: [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed.
Date: Wed, 31 Jan 2007 05:41:57 -0500 [thread overview]
Message-ID: <45C07275.9010501@garzik.org> (raw)
In-Reply-To: <20070131034424.8651.4713.stgit@localhost.localdomain>
Divy Le Ray wrote:
> From: Divy Le Ray <divy@chelsio.com>
>
> Offload packets may be DMAed long after their SGE Tx descriptors are done
> so they must remain mapped until they are freed rather than until their
> descriptors are freed. Unmap such packets through an skb destructor.
>
> Signed-off-by: Divy Le Ray <divy@chelsio.com>
this is questionable and sounds like you are working around a bug. I
can't think of another driver that uses skb destructors, and I could
have sworn that skb destructors were not for drivers to use anyway
Jeff
next prev parent reply other threads:[~2007-01-31 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 3:44 [PATCH 8/10] cxgb3 - Unmap offload packets when they are freed Divy Le Ray
2007-01-31 10:41 ` Jeff Garzik [this message]
2007-02-01 1:27 ` Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C07275.9010501@garzik.org \
--to=jeff@garzik.org \
--cc=None@chelsio.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.