From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: [PATCH] new domain builder fix to boot domU on IA64. Date: Wed, 31 Jan 2007 12:58:14 +0100 Message-ID: <45C08456.4080903@suse.de> References: <20070130122631.GI25482%yamahata@valinux.co.jp> <45BF50EC.4020300@suse.de> <20070131025608.GE23281%yamahata@valinux.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070131025608.GE23281%yamahata@valinux.co.jp> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Isaku Yamahata Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com List-Id: xen-devel@lists.xenproject.org Isaku Yamahata wrote: > XEN_DOMCTL_arch_setup hypercall sets up EFI memory map, > xen-faked EFI firmware and etc. So it should be called before > loading kernel/initrd images. Why is this order important? > How about adding new methods like setup_meminit, setup_firmware, setup_boot > (Or please suggest better names.) to struct xc_dom_loader? Certainly not to "struct xc_dom_loader", that one is for binary formats such as ELF and thus architecture-independant. Maybe we could put that into "struct xc_dom_arch". I've intentionally tried to keep the code which does hypercalls separately though. > And call setup_meminit at xc_dom_boot_mem_init(), > setup_firmware at the beginning of xc_dom_build_image(), > setup_boot at xc_dom_boot_image(). Only the xc_dom_boot_*() functions are supposed to invoke hypercalls. Thus the firmware setup can happen either at the end of xc_dom_boot_mem_init or at the start of xc_dom_boot_image. cheers, Gerd -- Gerd Hoffmann