From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Fix (hopefully) all the remaining problems with devices failing setup/identify
Date: Wed, 31 Jan 2007 12:22:24 -0500 [thread overview]
Message-ID: <45C0D050.4030302@garzik.org> (raw)
In-Reply-To: <20070131172605.2c5dfc78@localhost.localdomain>
Alan wrote:
> @@ -5142,6 +5174,20 @@
> status = ata_chk_status(ap);
> if (unlikely(status & ATA_BUSY))
> goto idle_irq;
> +
> + if (unlikely(qc->tf.command == ATA_CMD_SET_FEATURES &&
> + qc->tf.feature == SETFEATURES_XFER)) {
> + /* Let the timings change settle and the drive catch up as
> + some hardware needs up to 10uS to get its brain back in
> + gear. Taken from the workarounds in drivers/ide done by
> + Matthew Faupel/Niccolo Rigacci */
> + for (i = 0; i < 10; i++) {
> + if ((status & (ATA_BUSY | ATA_DRQ | ATA_ERR)) == 0)
> + break;
> + udelay(1);
> + status = ata_chk_status(ap);
> + }
Looks like you should use ata_busy_wait() here, rather than reproducing
the same code again.
Jeff
next prev parent reply other threads:[~2007-01-31 17:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 17:26 [PATCH] libata: Fix (hopefully) all the remaining problems with devices failing setup/identify Alan
2007-01-31 17:22 ` Jeff Garzik [this message]
2007-01-31 17:47 ` Alan
2007-02-02 16:54 ` Jeff Garzik
2007-02-02 18:23 ` Andrey Borzenkov
2007-02-06 13:42 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C0D050.4030302@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.