Re: [patch] not to disturb page LRU state when unmapping memory range

[Balbir Singh <balbir@in.ibm.com>]

Peter Zijlstra wrote:
[snip]

> It preserves the information, but not more.
> 
> Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
> ---
> diff --git a/mm/memory.c b/mm/memory.c
> index ef09f0a..b1f9129 100644
> --- a/mm/memory.c
> +++ b/mm/memory.c
> @@ -678,7 +678,7 @@ static unsigned long zap_pte_range(struct mmu_gather *tlb,
>  				if (pte_dirty(ptent))
>  					set_page_dirty(page);
>  				if (pte_young(ptent))
> -					mark_page_accessed(page);
> +					SetPageReferenced(page);
>  				file_rss--;
>  			}
>  			page_remove_rmap(page, vma);

Does it make sense to do this only for shared mapped pages?

if (pte_young(ptent) && (page_mapcount(page) > 1))
	SetPageReferenced(page);


	Balbir Singh

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>