All of lore.kernel.org
 help / color / mirror / Atom feed
From: Grzegorz Milos <gm281@cam.ac.uk>
To: Julian Stecklina <der_julian@web.de>
Cc: xen-devel@lists.xensource.com
Subject: Re: Re: Mini-OS in dom0 - virtual memory problems
Date: Thu, 01 Feb 2007 01:06:58 +0100	[thread overview]
Message-ID: <45C12F22.5020507@cam.ac.uk> (raw)
In-Reply-To: <epqsah$50f$1@sea.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

>> Mini-OS assumes that the start of the text section is also the 
>> beginning of virtual address space[1]. However, it is generally bad 
>> idea not to start virtual address space at 4Mb boundary. The easiest 
>> way to fix your problem is to move text to 0xc0000000 or 0xc0400000. 
>> More extensive fix, which decouples VIRT_START from &_text is also 
>> possible, but I don't see a reason why it would be needed. Instead 
>> I've included a runtime check. Keir could you apply the patch?
> 
> I changed the beginning of text to 0xC0000000 and the page table setup 
> seems to work, as does the rest of Mini-OS (except XenBus of course). 
> Thank you very much!

There was indeed a XenBus bug, where request structures wouldn't be 
marked as free (Keir could you apply the attached patch?), however I 
don't think that's what you are referring to. What problems do you observe?

Cheers
Gregor

[-- Attachment #2: mini-os.patch --]
[-- Type: text/plain, Size: 644 bytes --]

diff -r 34ab61cd89bb extras/mini-os/xenbus/xenbus.c
--- a/extras/mini-os/xenbus/xenbus.c	Tue Jan 30 21:26:45 2007 +0000
+++ b/extras/mini-os/xenbus/xenbus.c	Wed Jan 31 23:57:41 2007 +0000
@@ -178,6 +178,7 @@ static void release_xenbus_id(int id)
     BUG_ON(!req_info[id].in_use);
     spin_lock(&req_lock);
     nr_live_reqs--;
+    req_info[id].in_use = 0;
     if (nr_live_reqs == NR_REQS - 1)
         wake_up(&req_wq);
     spin_unlock(&req_lock);
@@ -212,6 +213,7 @@ static int allocate_xenbus_id(void)
     probe = o_probe + 1;
     spin_unlock(&req_lock);
     init_waitqueue_head(&req_info[o_probe].waitq);
+
     return o_probe;
 }
 

[-- Attachment #3: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

      reply	other threads:[~2007-02-01  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-25 13:49 Mini-OS in dom0 - virtual memory problems Julian Stecklina
2007-01-25 13:55 ` Julian Stecklina
2007-01-30 21:48 ` Grzegorz Milos
2007-01-31 19:57   ` Julian Stecklina
2007-02-01  0:06     ` Grzegorz Milos [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C12F22.5020507@cam.ac.uk \
    --to=gm281@cam.ac.uk \
    --cc=der_julian@web.de \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.