From mboxrd@z Thu Jan  1 00:00:00 1970
From: Gerd Hoffmann <kraxel@suse.de>
Subject: Re: [PATCH] new domain builder setup hook clean up (was Re:
	[PATCH] new domain builder fix to boot domU on IA64.)
Date: Thu, 01 Feb 2007 08:59:33 +0100
Message-ID: <45C19DE5.3090000@suse.de>
References: <20070130122631.GI25482%yamahata@valinux.co.jp>
	<45BF50EC.4020300@suse.de>
	<20070131025608.GE23281%yamahata@valinux.co.jp>
	<45C08456.4080903@suse.de>
	<20070201025719.GE23150%yamahata@valinux.co.jp>
Mime-Version: 1.0
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <20070201025719.GE23150%yamahata@valinux.co.jp>
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Isaku Yamahata <yamahata@valinux.co.jp>
Cc: xen-devel@lists.xensource.com, xen-ia64-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org


  Hi,

> @@ -438,7 +434,7 @@ int xc_dom_boot_mem_init(struct xc_dom_i
>  	return rc;
>      }
>  
> -    if (0 != (rc = arch_setup_middle(dom)))
> +    if (0 != (rc = arch_setup_bootearly(dom)))
>          return rc;
>  
>      return 0;

> @@ -497,6 +493,10 @@ int xc_dom_boot_image(struct xc_dom_imag
>  
>      xc_dom_printf("%s: called\n", __FUNCTION__);
>  
> +    /* misc ia64 stuff*/
> +    if (0 != (rc = arch_setup_bootearly(dom)))
> +	return rc;
> +
>      /* collect some info */
>      domctl.cmd = XEN_DOMCTL_getdomaininfo;
>      domctl.domain = dom->guest_domid;

Hmm, bootearly() is called twice now, I guess the first call in
mem_init() should have been removed?  Otherwise the patch looks fine to me.

cheers,
  Gerd

-- 
Gerd Hoffmann <kraxel@suse.de>