All of lore.kernel.org
 help / color / mirror / Atom feed
From: Timur Tabi <timur@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] Please pull from 'mpc83xx' branch
Date: Thu, 01 Feb 2007 10:06:36 -0600	[thread overview]
Message-ID: <45C2100C.6080505@freescale.com> (raw)
In-Reply-To: <8C8DE9C7-E818-43C6-8641-611365790846@kernel.crashing.org>

Kumar Gala wrote:

> This is on purpose, the boards in question are using the default value 
> of SCCR and have been.  Kim added the CFG_SCCR_* but it was never 
> actually used by the boards.

I got an email a way back from someone complaining that because the USB clocks 
were not being initialized on an 8349EMDS, the USB Linux driver was hanging on 
initialization.  I have not seen this myself, and I don't remember who sent the 
email, but whoever did was convinced that programming the clocks fixed the problem.

>> You can also probably get rid of these macros in mpc83xx.h:
>>
>> #define SCCR_ENCCM_0            0x00000000
>> #define SCCR_ENCCM_1            0x01000000
>> #define SCCR_ENCCM_2            0x02000000
>> #define SCCR_ENCCM_3            0x03000000
>> #define SCCR_TSEC1CM_0            0x00000000
>> #define SCCR_TSEC1CM_1            0x40000000
>> #define SCCR_TSEC1CM_2            0x80000000
>> #define SCCR_TSEC1CM_3            0xC0000000
>> #define SCCR_TSEC2CM_0            0x00000000
>> #define SCCR_TSEC2CM_1            0x10000000
>> #define SCCR_TSEC2CM_2            0x20000000
>> #define SCCR_TSEC2CM_3            0x30000000
>> #define SCCR_USBCM_0            0x00000000
>> #define SCCR_USBCM_1            0x00500000
>> #define SCCR_USBCM_2            0x00A00000
>> #define SCCR_USBCM_3            0x00F00000
> 
> Don't see any harm in having them.

Someone might seem them and think they should be used to initialize the clocks. 
  With the changes to cpu_init_f(), these macros will never be used.

-- 
Timur Tabi
Linux Kernel Developer @ Freescale

  reply	other threads:[~2007-02-01 16:06 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-30 21:34 [U-Boot-Users] Please pull from 'mpc83xx' branch Kumar Gala
2007-01-30 22:37 ` Wolfgang Denk
2007-01-30 22:49   ` Timur Tabi
2007-01-30 22:55     ` Kumar Gala
2007-01-31  0:26       ` Wolfgang Denk
2007-01-31 23:04 ` Timur Tabi
2007-02-01  4:26   ` Kumar Gala
2007-02-01 16:06     ` Timur Tabi [this message]
2007-02-01 16:39       ` Kumar Gala
2007-02-01 17:18         ` Timur Tabi
  -- strict thread matches above, loose matches on Subject: below --
2006-12-05 21:51 Kumar Gala
2006-12-14 22:18 ` Timur Tabi
2006-12-14 22:44   ` Kumar Gala
2006-12-14 22:47     ` Timur Tabi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C2100C.6080505@freescale.com \
    --to=timur@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.