From: Gerd Hoffmann <kraxel@suse.de>
To: John Levon <levon@movementarian.org>
Cc: xen-devel@lists.xensource.com
Subject: Re: new domain builder breaks compatibility
Date: Thu, 01 Feb 2007 17:33:20 +0100 [thread overview]
Message-ID: <45C21650.5020402@suse.de> (raw)
In-Reply-To: <20070201162259.GA31065@totally.trollied.org.uk>
John Levon wrote:
> On Thu, Feb 01, 2007 at 04:15:16PM +0100, Gerd Hoffmann wrote:
> Hmm... am I misunderstanding this code:
> 822 if ( (v_end - vstack_end) < (512UL << 10) )
> 823 {
> 824 /* Add extra 4MB to get >= 512kB padding. */
> 825 if ( !increment_ulong(&v_end, 1UL << 22) )
> 826 goto error_out;
> 827 }
No, you are right, it's 4MB unconditionally. Seems to have changed
though since I checked last time.
> Surely that guarantees we get at least 512Kb and it ends on a 4Mb
> boundary?
Yep. Is the 2MB alignment ok for Solaris? You can depend on the 512kb
only anyway, so the alignment shouldn't matter much ...
cheers,
Gerd
--
Gerd Hoffmann <kraxel@suse.de>
next prev parent reply other threads:[~2007-02-01 16:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 21:48 new domain builder breaks compatibility John Levon
2007-02-01 9:04 ` Gerd Hoffmann
2007-02-01 14:55 ` John Levon
2007-02-01 15:15 ` Gerd Hoffmann
2007-02-01 16:22 ` John Levon
2007-02-01 16:33 ` Gerd Hoffmann [this message]
2007-02-01 16:38 ` John Levon
2007-02-01 19:17 ` John Levon
2007-02-01 23:13 ` Keir Fraser
2007-02-02 7:59 ` Gerd Hoffmann
2007-02-02 15:08 ` Keir Fraser
2007-02-02 15:13 ` Gerd Hoffmann
2007-02-02 15:22 ` John Levon
2007-02-02 8:02 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C21650.5020402@suse.de \
--to=kraxel@suse.de \
--cc=levon@movementarian.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.