From: Scott Oom <other+qemudev@hoko.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page access
Date: Fri, 02 Feb 2007 00:20:41 -0500 [thread overview]
Message-ID: <45C2CA29.1010107@hoko.org> (raw)
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
Hello,
Found a problem when using small pages and getting permission faults.
This patch corrects the decoding of access permissions for small pages
on ARM, was just off by 2 bits.
-Scott
[-- Attachment #2: qemu-arm-mmu-smallpages-access.patch --]
[-- Type: text/x-patch, Size: 731 bytes --]
Index: target-arm/helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-arm/helper.c,v
retrieving revision 1.8
diff -u -3 -p -r1.8 helper.c
--- target-arm/helper.c 20 Jan 2007 17:12:09 -0000 1.8
+++ target-arm/helper.c 2 Feb 2007 05:12:03 -0000
@@ -338,7 +338,7 @@ static int get_phys_addr(CPUState *env,
break;
case 2: /* 4k page. */
phys_addr = (desc & 0xfffff000) | (address & 0xfff);
- ap = (desc >> (4 + ((address >> 13) & 6))) & 3;
+ ap = (desc >> (4 + ((address >> 11) & 6))) & 3; /* SRO */
break;
case 3: /* 1k page. */
if (type == 1) {
next reply other threads:[~2007-02-02 5:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 5:20 Scott Oom [this message]
2007-02-02 9:58 ` [Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page access Justin Fletcher
2007-02-02 17:48 ` Justin Fletcher
2007-02-02 18:33 ` Scott Oom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C2CA29.1010107@hoko.org \
--to=other+qemudev@hoko.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.