From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: xensource (pci) device id's? Date: Fri, 02 Feb 2007 10:47:17 +0100 Message-ID: <45C308A5.4060100@suse.de> References: <45C1F0E1.1070204@suse.de> <1170338316.4294.25.camel@localhost.localdomain> <45C1F970.3060909@suse.de> <45C20B22.9090802@suse.de> <1170408394.4294.76.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1170408394.4294.76.camel@localhost.localdomain> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Ian Campbell Cc: Xen devel list List-Id: xen-devel@lists.xenproject.org Ian Campbell wrote: > On Thu, 2007-02-01 at 16:45 +0100, Gerd Hoffmann wrote: >> kbd->name = "Xen Virtual Keyboard"; >> + kbd->id.bustype = BUS_PCI; >> + kbd->id.vendor = 0x5853; /* XenSource, Inc. */ >> + kbd->id.product = 0x0002; >> ptr->name = "Xen Virtual Pointer"; >> + ptr->id.bustype = BUS_PCI; >> + ptr->id.vendor = 0x5853; /* XenSource, Inc. */ >> + ptr->id.product = 0x0003; > > This isn't strictly true because this isn't really a PCI device. Is > BUS_HOST not more appropriate? Reason I've picked PCI is simply because they are taken from PCI namespace. > Possibly we could still use our PCI vendor/product IDs since I guess > they are pretty arbitrary with in the BUS_HOST namespace. What does the > input layer do with these values anyway? Nothing. It's for userspace, to make detection and configuration easier. In practice it probably doesn't matter much whenever it is BUS_PCI or BUS_HOST. But we should stick with the one we pick ... cheers, Gerd -- Gerd Hoffmann