From: Jeff Garzik <jeff@garzik.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Michael K. Edwards" <medwards.linux@gmail.com>,
Linux Kernel List <linux-kernel@vger.kernel.org>
Subject: Re: Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr?
Date: Fri, 02 Feb 2007 06:07:50 -0500 [thread overview]
Message-ID: <45C31B86.6070009@garzik.org> (raw)
In-Reply-To: <45C2DA8D.4050007@zytor.com>
H. Peter Anvin wrote:
> Jeff Garzik wrote:
>> Volatile is usually reserved for a specific need on a specific arch.
>> I doubt it is correct to force it on all arches.
>
> They already are volatile; the issue is adding "const".
>
> All io(read|write)* pointers are volatile, IIRC.
No, none are volatile, hence my comment.
> [jgarzik@pretzel linux-2.6]$ grep volatile lib/iomap.c include/asm-generic/iomap.h
> [jgarzik@pretzel linux-2.6]$
Maybe you were thinking about writel() and friends, whose implementation
(not prototype!) includes use of volatile.
Regards,
Jeff
next prev parent reply other threads:[~2007-02-02 11:07 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f2b55d220702011624v6cb13c8ct1d70863a661d2227@mail.gmail.com>
2007-02-02 0:35 ` Should io(read|write)(8|16|32)_rep take (const|) volatile u(8|16|32) __iomem *addr? Michael K. Edwards
2007-02-02 3:15 ` H. Peter Anvin
2007-02-02 6:04 ` Jeff Garzik
2007-02-02 6:30 ` H. Peter Anvin
2007-02-02 11:07 ` Jeff Garzik [this message]
2007-02-02 19:58 ` Michael K. Edwards
2007-02-02 21:40 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C31B86.6070009@garzik.org \
--to=jeff@garzik.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=medwards.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.