From: Larry Finger <larry.finger@lwfinger.net>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Michael Buesch <mb@bu3sch.de>,
netdev@vger.kernel.org, Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] ieee80211: Fix sparse warning
Date: Fri, 02 Feb 2007 15:38:09 -0600 [thread overview]
Message-ID: <45C3AF41.1030908@lwfinger.net> (raw)
In-Reply-To: <20070202203201.GB9382@tuxdriver.com>
John W. Linville wrote:
> On Wed, Jan 31, 2007 at 06:50:19PM -0600, Larry Finger wrote:
>> Sparse issues the warning "warning: symbol 'crypt' shadows an earlier one"
>> in net/ieee80211/ieee80211_tx.c.
>>
>> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
>> ---
>>
>> Index: wireless-2.6/net/ieee80211/ieee80211_tx.c
>> ===================================================================
>> --- wireless-2.6.orig/net/ieee80211/ieee80211_tx.c
>> +++ wireless-2.6/net/ieee80211/ieee80211_tx.c
>> @@ -502,8 +502,6 @@ int ieee80211_xmit(struct sk_buff *skb,
>> if (host_encrypt)
>> ieee80211_encrypt_fragment(ieee, skb_frag, hdr_len);
>> else if (host_build_iv) {
>> - struct ieee80211_crypt_data *crypt;
>> -
>> crypt = ieee->crypt[ieee->tx_keyidx];
>> atomic_inc(&crypt->refcnt);
>> if (crypt->ops->build_iv)
>
> Couldn't you remove the "crypt = ieee->crypt[ieee->tx_keyidx];"
> as well?
Yes it can. I'll send a revised patch along shortly.
Larry
prev parent reply other threads:[~2007-02-02 21:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-01 0:50 [PATCH] ieee80211: Fix sparse warning Larry Finger
2007-02-02 20:32 ` John W. Linville
2007-02-02 21:38 ` Larry Finger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C3AF41.1030908@lwfinger.net \
--to=larry.finger@lwfinger.net \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.