From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] sl82c105: DMA support fixes
Date: Sat, 03 Feb 2007 00:04:18 +0100 [thread overview]
Message-ID: <45C3C372.90400@gmail.com> (raw)
In-Reply-To: <58cb370e0702021350h7aa08ddbo11a4cb0bb3e8e148@mail.gmail.com>
Sergei Shtylyov wrote:
>
> Fix a number of issues with the DMA support code:
>
> - driver claims support for all SW/MW DMA modes while supporting only MWDMA2;
>
> - ide_dma_check() method tries to enable DMA on the "known good" drives which
> don't support MWDMA2;
>
> - ide_dma_on() method upon failure to set drive to MWDMA2 re-tunes already
> tuned PIO mode and calls ide_dma_off() method instead of returning error;
>
> - ide_dma_off() method sets drive->current_speed while it doesn't actually
> change (only the PIO timings are re-loaded into the chip's registers);
>
> - init_hwif() method forcibly sets/resets both "drive DMA capable" bits while
> this is properly handled by ide_dma_{on,off}() methods being called later...
>
> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>
applied
prev parent reply other threads:[~2007-02-02 22:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-30 20:32 [PATCH] sl82c105: DMA support fixes Sergei Shtylyov
[not found] ` <58cb370e0702021350h7aa08ddbo11a4cb0bb3e8e148@mail.gmail.com>
2007-02-02 23:04 ` Bartlomiej Zolnierkiewicz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C3C372.90400@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.