All of lore.kernel.org
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] parport EPP support for Linux
Date: Mon, 05 Feb 2007 00:25:00 +0100	[thread overview]
Message-ID: <45C66B4C.3020008@bellard.org> (raw)
In-Reply-To: <9cfa10eb0702041236x12b69e2ai269f9a79b6b344f2@mail.gmail.com>

Marko Kohtala wrote:
> Hi.
> 
> With the attached patch I am able to use Kodak Advantix FD 300 APS
> scanner from Win98 when hosted under Linux ix86. It adds EPP support
> and fixes some register bits to match real hw so port identification
> works better.
> 
> I tried to separate the linux dependencies with #ifdef __linux__, but
> can not test this does not break compilation for other ports of qemu.
> 
> Suggestions are welcome, but I also welcome you to make the
> enhancements yourself. This is good enough for me.
> 
> I hope it is good enough for inclusion in Qemu. It applies and was
> tested against current CVS.

I don't understand why you need a #ifdef __linux__ in parallel.c. 
Normally, the qemu character device should suffice to do the appropriate 
abstraction.

Regards,

Fabrice.

  parent reply	other threads:[~2007-02-04 23:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-04 20:36 [Qemu-devel] [PATCH] parport EPP support for Linux Marko Kohtala
2007-02-04 20:40 ` [Qemu-devel] " Marko Kohtala
2007-02-04 23:25 ` Fabrice Bellard [this message]
  -- strict thread matches above, loose matches on Subject: below --
2007-02-05  6:06 [Qemu-devel] " Marko Kohtala
2007-02-12 19:02 ` Marko Kohtala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C66B4C.3020008@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.