From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gerd Hoffmann Subject: Re: xensource (pci) device id's? Date: Mon, 05 Feb 2007 09:55:47 +0100 Message-ID: <45C6F113.9000508@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Keir Fraser Cc: Xen devel list , Ian Campbell List-Id: xen-devel@lists.xenproject.org Keir Fraser wrote: > On 1/2/07 15:45, "Gerd Hoffmann" wrote: > >> kbd->name = "Xen Virtual Keyboard"; >> + kbd->id.bustype = BUS_PCI; >> + kbd->id.vendor = 0x5853; /* XenSource, Inc. */ >> + kbd->id.product = 0x0002; >> ptr->name = "Xen Virtual Pointer"; >> + ptr->id.bustype = BUS_PCI; >> + ptr->id.vendor = 0x5853; /* XenSource, Inc. */ >> + ptr->id.product = 0x0003; > > Instead of faking out PCI device ids, which is kinda bogus, can you match in > the X config file based on the string(s) in {kbd,ptr}->{name,phys,uniq}? > That'd be nicer than pulling random id numbers out of the air. You can match name, phys, bustype, vendor, product and version. Thus a string in phys should work. "xenbus/" + nodename maybe? Nevertheless I think some vendor and product id would be nice, usb hid devices are usually identified using these two, so having something useful filled in makes things easier ... cheers, Gerd -- Gerd Hoffmann