All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tejun Heo <htejun@gmail.com>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH libata-dev#upstream 2/2] pata_amd: don't configure udma mode faster than BIOS did
Date: Mon, 05 Feb 2007 21:36:51 +0900	[thread overview]
Message-ID: <45C724E3.6000909@gmail.com> (raw)
In-Reply-To: <20070205112533.611558c2@localhost.localdomain>

Alan wrote:
>> This patch implements mode_filter for pata_amd which makes it avoid
>> configuring udma mode higher than BIOS did.
>>
>> Signed-off-by: Tejun Heo <htejun@gmail.com>
> 
> NAK, wrong for the same reason as it is wrong on the IDE one, and even
> more so as we will support hotplug and the like in time too.

Yeap, it's wrong for hotplug but...

1. I don't think PATA hotplug is gonna be popular and even if we get
autodetection wrong (slower than optimal, which is way better than
faster than possible) on hotplug, we can allow the user to tune it
afterwards.

2. We don't have any way to detect cable type reliably on that
controller, so getting cable type correctly automatically on hotplug is
impossible anyway.

Thanks.

-- 
tejun

  reply	other threads:[~2007-02-05 12:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05  8:05 [PATCH libata-dev#upstream 1/2] libata: export several functions Tejun Heo
2007-02-05  8:08 ` [PATCH libata-dev#upstream 2/2] pata_amd: don't configure udma mode faster than BIOS did Tejun Heo
2007-02-05 11:25   ` Alan
2007-02-05 12:36     ` Tejun Heo [this message]
2007-02-05 13:26       ` Alan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C724E3.6000909@gmail.com \
    --to=htejun@gmail.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=jeff@garzik.org \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.