All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomonari Horikoshi <t.horikoshi@jp.fujitsu.com>
To: xen-devel <xen-devel@lists.xensource.com>
Cc: xen-ia64-devel <xen-ia64-devel@lists.xensource.com>
Subject: Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len
Date: Thu, 25 Jan 2007 13:44:30 +0900	[thread overview]
Message-ID: <45C7403B802BFEt.horikoshi@jp.fujitsu.com> (raw)
In-Reply-To: <20070124022951.GA6701@gondor.apana.org.au>

Hi Herbert-san

Thank you for your comment.

I agreed.
I examine the another way. 

It is likely to go well if something is added to the check 
on netfront_tx_slot_available(). 

Best regards.

Tomonari Horikoshi,

Herbert Xu wrote:----------------------
Sent:    Wed, 24 Jan 2007 13:29:51 +1100
Subject: Re: [Xen-devel] [PATCH] Add netfornt tx_queue_len

> On Wed, Jan 24, 2007 at 01:37:55AM +0000, Tomonari Horikoshi wrote:
> > 
> > When I executed "netperf" by a short message of UDP, 
> > PV domain and PV-on-HVM driver issued Call trace.
> > 
> > I think that GrantEntry was filled with a lot of messages processings.
> > 
> > This problem is generated in IA64 only.
> > Probably, I think that I am the following problems. 
> > 
> >   In IA64
> >     NET_TX_RING_SIZE 1024,  NR_GRANT_ENTRIES 2048
> >   In x86
> >     NET_TX_RING_SIZE  256,  NR_GRANT_ENTRIES 2048
> > 
> > I corrected to check "number of unprocessing queue > tx_queue_len" before Grant was filled.
> > 
> > However, my correction influences x86. 
> > Please teach to me in that when there is a better improvement. 
> 
> Sorry, but this patch looks bogus.  The tx queue is maintained by
> Linux and has nothing to do with the driver.  So limiting its length
> based on internal state of the driver can't be right.
> 
> We need to find out what's really going wrong with the grant table
> entries here.
> 
> Cheers,
> -- 
> Visit Openswan at http://www.openswan.org/
> Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
> Home Page: http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel

      reply	other threads:[~2007-01-25  4:44 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-24  1:37 [PATCH] Add netfornt tx_queue_len Tomonari Horikoshi
2007-01-24  2:29 ` Herbert Xu
2007-01-25  4:44   ` Tomonari Horikoshi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C7403B802BFEt.horikoshi@jp.fujitsu.com \
    --to=t.horikoshi@jp.fujitsu.com \
    --cc=xen-devel@lists.xensource.com \
    --cc=xen-ia64-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.