All of lore.kernel.org
 help / color / mirror / Atom feed
From: Auke Kok <auke-jan.h.kok@intel.com>
To: "Ahmed S. Darwish" <darwish.07@gmail.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	jeffrey.t.kirsher@intel.com, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 2.6.20] ixgb: Use ARRAY_SIZE macro when appropriate
Date: Mon, 05 Feb 2007 12:31:26 -0800	[thread overview]
Message-ID: <45C7941E.2050305@intel.com> (raw)
In-Reply-To: <20070205201804.GC11055@martell.zuzino.mipt.ru>

Alexey Dobriyan wrote:
> On Mon, Feb 05, 2007 at 06:59:33PM +0200, Ahmed S. Darwish wrote:
>> A patch to use ARRAY_SIZE macro already defined in kernel.h.
> 
> Remove it and use ARRAY_SIZE instead.
> 
>> --- a/drivers/net/ixgb/ixgb_param.c
>> +++ b/drivers/net/ixgb/ixgb_param.c
>> @@ -245,7 +245,7 @@ ixgb_validate_option(int *value, struct ixgb_option *opt)
>>  	return -1;
>>  }
>>  
>> -#define LIST_LEN(l) (sizeof(l) / sizeof(l[0]))
>> +#define LIST_LEN(l) ARRAY_SIZE(l)

yes, well spotted. Please change line 338 in this file to read:

      .arg  = { .l = { .nr = ARRAY_SIZE(fc_list),

instead, so you can remove the LIST_LEN macro completely.

Thanks,

Auke

  reply	other threads:[~2007-02-05 20:31 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 16:54 [PATCH 00] A series of patches to use ARRAY_SIZE in `net' drivers Ahmed S. Darwish
2007-02-05 16:55 ` [PATCH 2.6.20] e1000: Use ARRAY_SIZE macro when appropriate Ahmed S. Darwish
2007-02-06 17:16   ` Auke Kok
2007-02-05 16:56 ` [PATCH 2.6.20] ipw2100: " Ahmed S. Darwish
2007-02-05 16:56 ` [PATCH 01/02] misc-net-drivers: " Ahmed S. Darwish
2007-02-05 16:57   ` [PATCH 02/02] " Ahmed S. Darwish
2007-02-05 16:58 ` [PATCH 2.6.20] misc-wireless: " Ahmed S. Darwish
2007-02-05 16:58 ` [PATCH 2.6.20] hostap: " Ahmed S. Darwish
2007-02-05 16:59 ` [PATCH 2.6.20] ibm_emac: " Ahmed S. Darwish
2007-02-05 16:59   ` Ahmed S. Darwish
2007-02-05 20:22   ` Alexey Dobriyan
2007-02-05 20:22     ` Alexey Dobriyan
2007-02-06  9:12     ` Ahmed S. Darwish
2007-02-06  9:12       ` Ahmed S. Darwish
2007-02-05 16:59 ` [PATCH 2.6.20] ixgb: " Ahmed S. Darwish
2007-02-05 20:18   ` Alexey Dobriyan
2007-02-05 20:31     ` Auke Kok [this message]
2007-02-06 10:00       ` Ahmed S. Darwish
2007-02-06 16:48         ` Auke Kok
2007-02-05 17:00 ` [PATCH 2.6.20] wavelan: " Ahmed S. Darwish
2007-02-05 20:17   ` Alexey Dobriyan
2007-02-06  9:34     ` Ahmed S. Darwish

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C7941E.2050305@intel.com \
    --to=auke-jan.h.kok@intel.com \
    --cc=adobriyan@gmail.com \
    --cc=darwish.07@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.