From: Zachary Amsden <zach@vmware.com>
To: Zachary Amsden <zach@vmware.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>, Andi Kleen <ak@muc.de>,
Rusty Russell <rusty@rustcorp.com.au>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH 2/11] Sched clock paravirt op
Date: Mon, 05 Feb 2007 20:00:47 -0800 [thread overview]
Message-ID: <45C7FD6F.2070402@vmware.com> (raw)
In-Reply-To: <200702060352.l163qeAf000727@zach-dev.vmware.com>
Zachary Amsden wrote:
>
> #include "mach_timer.h"
>
> @@ -102,9 +103,6 @@ unsigned long long sched_clock(void)
> {
> unsigned long long this_offset;
>
> - if (unlikely(custom_sched_clock))
> - return (*custom_sched_clock)();
> -
> /*
> * Fall back to jiffies if there's no TSC available:
> */
> @@ -113,13 +111,13 @@ unsigned long long sched_clock(void)
> return (jiffies_64 - INITIAL_JIFFIES) * (1000000000 / HZ);
>
> /* read the Time Stamp Counter: */
> - rdtscll(this_offset);
> + get_scheduled_cycles(this_offset);
>
> /* return the value in ns */
> return cycles_2_ns(this_offset);
> }
>
I missed a title / signed-off on this guy.
Internally, sched_clock runs in units of nanoseconds, not CPU cycles.
This was wrong in my previous patch. Fix it so everyone can use the
same cycles_2_ns code in tsc.c.
Signed-off-by: Zachary Amsden <zach@vmware.com>
next prev parent reply other threads:[~2007-02-06 4:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 3:52 [PATCH 2/11] Sched clock paravirt op Zachary Amsden
2007-02-06 4:00 ` Zachary Amsden [this message]
2007-02-06 12:32 ` Andi Kleen
2007-02-06 22:47 ` Zachary Amsden
2007-02-06 23:23 ` Jeremy Fitzhardinge
2007-02-06 23:42 ` Zachary Amsden
2007-02-06 23:48 ` Jeremy Fitzhardinge
2007-02-06 23:50 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C7FD6F.2070402@vmware.com \
--to=zach@vmware.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.