All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tolunay Orkun <listmember@orkun.us>
To: u-boot@lists.denx.de
Subject: [U-Boot-Users] [PATCH] Add sync at the end of flash_write_cmd for MPC86xx
Date: Tue, 06 Feb 2007 02:50:08 -0600	[thread overview]
Message-ID: <45C84140.3010909@orkun.us> (raw)
In-Reply-To: <200702060806.50420.sr@denx.de>

Stefan Roese wrote:
> On Monday 05 February 2007 22:11, Haavard Skinnemoen wrote:
>>> #ifdef SYNC
>>>     SYNC;
>>> #endif
>> Better to drop the #ifdef and just add empty stubs for the arches that
>> don't need it.
> 
> Yes, please do it this way.

I think defining the SYNC macro in architecture files is probably better 
but #ifdef wrapper would avoid touching architectures that does not have 
SYNC concept.

I guess at this moment we need a real (not a stub) SYNC for all PowerPC 
variants and Blackfin. I do not know if other architectures supported by 
U-Boot have such instructions in instruction set. So, it is probably the 
best time for those architecture people to speak up.

I think this patch should be independent than the cfi_flash.c patch. 
cfi_flash.c patch will depend on this patch applied first.

Best regards,
Tolunay

  reply	other threads:[~2007-02-06  8:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-05 20:19 [U-Boot-Users] [PATCH] Add sync at the end of flash_write_cmd for MPC86xx Haiying Wang
2007-02-05 21:01 ` Andrew Dyer
2007-02-05 21:11   ` Haavard Skinnemoen
2007-02-06  7:06     ` Stefan Roese
2007-02-06  8:50       ` Tolunay Orkun [this message]
2007-02-06 11:31         ` Haavard Skinnemoen
2007-02-05 21:11   ` Haiying Wang
2007-02-06  9:10 ` Tolunay Orkun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45C84140.3010909@orkun.us \
    --to=listmember@orkun.us \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.