From: Zachary Amsden <zach@vmware.com>
To: Andi Kleen <ak@muc.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@osdl.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Jeremy Fitzhardinge <jeremy@goop.org>,
Chris Wright <chrisw@sous-sol.org>
Subject: Re: [PATCH 6/11] Vmi timer no idle hz fixes.patch
Date: Tue, 06 Feb 2007 16:22:51 -0800 [thread overview]
Message-ID: <45C91BDB.9060403@vmware.com> (raw)
In-Reply-To: <20070206122917.GD47229@muc.de>
Andi Kleen wrote:
>> -#ifdef CONFIG_S390
>> -#ifdef CONFIG_MATHEMU
>> - {
>> - .ctl_name = KERN_IEEE_EMULATION_WARNINGS,
>> - .procname = "ieee_emulation_warnings",
>> - .data = &sysctl_ieee_emulation_warnings,
>> - .maxlen = sizeof(int),
>> - .mode = 0644,
>> - .proc_handler = &proc_dointvec,
>> - },
>>
>
> I think there needs to be a way to have this syctl only
> when it's really implemented for the paravirt ops.
>
> I suppose you should move it to dynamic registration on demand.
>
Hmm, is there a way to do that and share the sysctl with Xen? Yes, I
think if we move the data to paravirt.c and call
paravirt_start_no_idle_hz (or something_with_fewer_underbars), then we
can both share this call site instead of silly duplicating the .ctl_name ...
Will code it up.
Zach
next prev parent reply other threads:[~2007-02-07 0:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-06 3:53 [PATCH 6/11] Vmi timer no idle hz fixes.patch Zachary Amsden
2007-02-06 12:29 ` Andi Kleen
2007-02-07 0:22 ` Zachary Amsden [this message]
2007-02-07 1:05 ` Zachary Amsden
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45C91BDB.9060403@vmware.com \
--to=zach@vmware.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=chrisw@sous-sol.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.