All of lore.kernel.org
 help / color / mirror / Atom feed
From: Geoff Levand <geoffrey.levand@am.sony.com>
To: Geert Uytterhoeven <Geert.Uytterhoeven@sonycom.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/3] PS3: System manager support
Date: Wed, 07 Feb 2007 09:04:31 -0800	[thread overview]
Message-ID: <45CA069F.7060108@am.sony.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0702071527350.29060@pademelon.sonytel.be>

Geert Uytterhoeven wrote:
> On Tue, 6 Feb 2007, Geoff Levand wrote:
>> --- ps3-linux-dev.orig/arch/powerpc/platforms/ps3/setup.c
>> +++ ps3-linux-dev/arch/powerpc/platforms/ps3/setup.c
>> @@ -42,6 +42,10 @@
>>  #define DBG(fmt...) do{if(0)printk(fmt);}while(0)
>>  #endif
>>  
>> +#if !defined(CONFIG_SMP)
>> +static void smp_send_stop(void) {}
>> +#endif
> 
> Shouldn't this be added to include/linux/smp.h instead? That header file
> already contains some dummy definitions for the non-SMP case.

Sounds like a good idea.  I'll prepare a seperate patch that does it.

-Geoff

  reply	other threads:[~2007-02-07 17:04 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-06 22:23 [PATCH 3/3] PS3: System manager support Geoff Levand
2007-02-07  0:00 ` Michael Ellerman
2007-02-07  1:16   ` Geoff Levand
2007-02-07  3:41     ` Michael Ellerman
2007-02-07  3:53       ` Geoff Levand
2007-02-07 14:28 ` Geert Uytterhoeven
2007-02-07 17:04   ` Geoff Levand [this message]
2007-02-07 20:20 ` [PATCH 3/3 v2] " Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CA069F.7060108@am.sony.com \
    --to=geoffrey.levand@am.sony.com \
    --cc=Geert.Uytterhoeven@sonycom.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.