From: Lachlan McIlroy <lachlan@sgi.com>
To: Christoph Hellwig <hch@lst.de>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] use struct kvec in struct uio
Date: Wed, 07 Feb 2007 18:02:29 +0000 [thread overview]
Message-ID: <45CA1435.7050100@sgi.com> (raw)
In-Reply-To: <20070207125446.GB7740@lst.de>
Christoph,
Looks like another lost take message to oss.
mod xfs-linux-melb:xfs-kern:27701a TAKE message
================================================
Subject: TAKE 954580 -
use struct kvec in struct uio
Date: Tue Dec 12 13:13:14 AEDT 2006
Workarea: vpn-emea-sw-emea-160-4.emea.sgi.com:/home/lachlan/isms/2.6.x-xfs
Inspected by: hch
Author: lachlan
The following file(s) were checked into:
longdrop.melbourne.sgi.com:/isms/linux/2.6.x-xfs-melb
Modid: xfs-linux-melb:xfs-kern:27701a
fs/xfs/support/move.h - 1.19 - changed
fs/xfs/linux-2.6/xfs_ioctl.c - 1.140 - changed
fs/xfs/dmapi/xfs_dm.c - 1.31 - changed
- use struct kvec in struct uio
I also included this change to fix a warning introduced with your patch.
*** /usr/tmp/TmpDir.8968-0/fs/xfs/dmapi/xfs_dm.c_1.30 2007-02-07 18:00:52.000000000 +0000
--- /usr/tmp/TmpDir.8968-0/fs/xfs/dmapi/xfs_dm.c_1.31 2007-02-07 18:00:52.000000000 +0000
***************
*** 928,934 ****
{
int sink;
struct uio auio;
! struct iovec aiov;
int rval;
*nreadp = 0;
--- 928,934 ----
{
int sink;
struct uio auio;
! iovec_t aiov;
int rval;
*nreadp = 0;
Lachlan
Christoph Hellwig wrote:
> On Wed, Nov 29, 2006 at 04:46:07PM +0100, Christoph Hellwig wrote:
>
>>All but one useage of struct uio are for kernel pointers, so let's use
>>struct kvec instead of struct iovec. Because readlink by handle still
>>uses it with a user pointer we still have two sparse warnings, but the
>>noise level is reduced quite a bit by this.
>
>
> ping?
>
>
>>
>>Signed-off-by: Christoph Hellwig <hch@lst.de>
>>
>>Index: linux-2.6/fs/xfs/support/move.h
>>===================================================================
>>--- linux-2.6.orig/fs/xfs/support/move.h 2006-11-29 16:27:25.000000000 +0100
>>+++ linux-2.6/fs/xfs/support/move.h 2006-11-29 16:30:18.000000000 +0100
>>@@ -55,7 +55,7 @@
>> };
>>
>> struct uio {
>>- struct iovec *uio_iov; /* pointer to array of iovecs */
>>+ struct kvec *uio_iov; /* pointer to array of iovecs */
>> int uio_iovcnt; /* number of iovecs in array */
>> xfs_off_t uio_offset; /* offset in file this uio corresponds to */
>> int uio_resid; /* residual i/o count */
>>@@ -63,7 +63,7 @@
>> };
>>
>> typedef struct uio uio_t;
>>-typedef struct iovec iovec_t;
>>+typedef struct kvec iovec_t;
>>
>> extern int xfs_uio_read (caddr_t, size_t, uio_t *);
>>
>>Index: linux-2.6/fs/xfs/linux-2.6/xfs_ioctl.c
>>===================================================================
>>--- linux-2.6.orig/fs/xfs/linux-2.6/xfs_ioctl.c 2006-11-29 16:33:37.000000000 +0100
>>+++ linux-2.6/fs/xfs/linux-2.6/xfs_ioctl.c 2006-11-29 16:34:43.000000000 +0100
>>@@ -388,7 +388,7 @@
>> aiov.iov_len = olen;
>> aiov.iov_base = hreq.ohandle;
>>
>>- auio.uio_iov = &aiov;
>>+ auio.uio_iov = (struct kvec *)&aiov;
>> auio.uio_iovcnt = 1;
>> auio.uio_offset = 0;
>> auio.uio_segflg = UIO_USERSPACE;
>
> ---end quoted text---
>
>
prev parent reply other threads:[~2007-02-07 18:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-29 15:46 [PATCH] use struct kvec in struct uio Christoph Hellwig
2007-02-07 12:54 ` Christoph Hellwig
2007-02-07 18:02 ` Lachlan McIlroy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CA1435.7050100@sgi.com \
--to=lachlan@sgi.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.