All of lore.kernel.org
 help / color / mirror / Atom feed
From: Karl MacMillan <kmacmillan@mentalrootkit.com>
To: Stephen Smalley <sds@tycho.nsa.gov>
Cc: Daniel J Walsh <dwalsh@redhat.com>, SE Linux <selinux@tycho.nsa.gov>
Subject: Re: Small patch to allow semodule_deps to build
Date: Thu, 08 Feb 2007 16:03:55 -0500	[thread overview]
Message-ID: <45CB903B.9050109@mentalrootkit.com> (raw)
In-Reply-To: <1170950373.11912.276.camel@moss-spartans.epoch.ncsc.mil>

Stephen Smalley wrote:
> On Thu, 2007-02-08 at 10:16 -0500, Karl MacMillan wrote:
>> Daniel J Walsh wrote:
>>>
>>> ------------------------------------------------------------------------
>>>
>>> --- nsapolicycoreutils/semodule_deps/semodule_deps.c	2007-02-07 12:11:49.000000000 -0500
>>> +++ policycoreutils-2.0.0/semodule_deps/semodule_deps.c	2007-02-07 16:46:18.000000000 -0500
>>> @@ -16,7 +16,7 @@
>>>   * of avrule_blocks - even in an ABI safe way - seems undesirable.
>>>   */
>>>  #include <sepol/module.h>
>>> -#include <sepol/errno.h>
>>> +#include <sepol/errcodes.h>
>>>  #include <sepol/policydb/policydb.h>
>>>  
>>>  #include <getopt.h>
>> This shouldn't be necessary - errcodes.h should be included via 
>> policydb.h -> symtab.h -> hashtab.h. Also, I can't reproduce this locally.
> 
> Actually, Dan is correct at least in removing #include <sepol/errno.h> -
> that was what you had originally called the header, but renamed to
> errcodes.h in response to my comments.  So you (and I) had a lingering
> errno.h left around from previous builds that obscured the broken build.
> cd trunk/
> rm -rf ~/obj
> make DESTDIR=~/obj install
> to reproduce.
> 

Yep - guess my process needs a little fixing.

Acked-by: Karl MacMillan <kmacmillan@mentalrootkit.com> and merged as 
policycoreutils 2.0.1.

--
This message was distributed to subscribers of the selinux mailing list.
If you no longer wish to subscribe, send mail to majordomo@tycho.nsa.gov with
the words "unsubscribe selinux" without quotes as the message.

      reply	other threads:[~2007-02-08 21:03 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-07 21:52 Small patch to allow semodule_deps to build Daniel J Walsh
2007-02-08 15:16 ` Karl MacMillan
2007-02-08 15:59   ` Stephen Smalley
2007-02-08 21:03     ` Karl MacMillan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45CB903B.9050109@mentalrootkit.com \
    --to=kmacmillan@mentalrootkit.com \
    --cc=dwalsh@redhat.com \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.