From: Joseph Jezak <josejx@gentoo.org>
To: Michael Buesch <mb@bu3sch.de>
Cc: Larry Finger <Larry.Finger@lwfinger.net>,
netdev@vger.kernel.org, linux-wireless@vger.kernel.org,
John Linville <linville@tuxdriver.com>,
Bcm43xx-dev@lists.berlios.de
Subject: Re: [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007
Date: Fri, 09 Feb 2007 14:17:09 -0500 [thread overview]
Message-ID: <45CCC8B5.3060108@gentoo.org> (raw)
In-Reply-To: <200702091945.25187.mb@bu3sch.de>
>
> The specs are unclear at this point:
> "Write the value to the offset"
> Offset in which register type?
PHY Register. I've clarified it in the specs, I think this was said
before, I made it worse when I cleaned it up.
>> // Initialization
>> - if (phy->version == 0) {
>> + if (phy->analog == 0) {
>> bcm43xx_write16(bcm, 0x03E6, 0x0122);
>> } else {
>> - if (phy->version >= 2)
>> - bcm43xx_write16(bcm, 0x03E6, 0x0040);
>> + if (phy->analog >= 2)
>> + bcm43xx_write16(bcm, 0x0003, (bcm43xx_read16(bcm, 0x0003)
>> + & 0xFFBF) | 0x0040);
>
> I think here is a specs bug.
This is correct. Why do you think it's a specs bug?
-Joe
next prev parent reply other threads:[~2007-02-09 19:17 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-09 16:32 [PATCH] bcm43xx: Fix code for spec changes of 2/7/2007 Larry Finger
2007-02-09 17:11 ` Michael Buesch
2007-02-09 18:11 ` Larry Finger
2007-02-09 22:22 ` Joseph Jezak
2007-02-09 17:29 ` Michael Buesch
2007-02-09 18:21 ` Larry Finger
2007-02-09 18:48 ` Michael Buesch
2007-02-09 19:05 ` Joseph Jezak
2007-02-09 19:17 ` Michael Buesch
2007-02-09 19:55 ` Joseph Jezak
2007-02-09 20:30 ` Michael Buesch
2007-02-14 12:52 ` Johannes Berg
2007-02-14 19:13 ` Larry Finger
2007-02-14 19:26 ` Johannes Berg
2007-02-14 19:27 ` Johannes Berg
2007-02-14 21:52 ` Michael Buesch
2007-02-14 22:28 ` Larry Finger
2007-02-09 19:26 ` Larry Finger
2007-02-09 21:32 ` Matthew Garrett
2007-02-09 22:52 ` Martin Langer
2007-02-10 5:55 ` Michael Buesch
2007-02-10 12:57 ` Matthew Garrett
2007-02-27 17:00 ` Gavin McCullagh
2007-02-11 2:13 ` Joseph Jezak
2007-02-14 13:18 ` Johannes Berg
2007-02-14 21:40 ` Michael Buesch
2007-02-15 15:07 ` Johannes Berg
2007-02-15 15:13 ` Michael Buesch
2007-02-15 15:19 ` Johannes Berg
2007-02-15 16:51 ` Martin Langer
2007-02-15 16:53 ` Johannes Berg
2007-02-11 13:21 ` Johannes Berg
2007-02-09 18:45 ` Michael Buesch
2007-02-09 19:17 ` Joseph Jezak [this message]
2007-02-09 19:26 ` Michael Buesch
2007-02-09 19:58 ` Joseph Jezak
2007-02-09 22:24 ` Joseph Jezak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45CCC8B5.3060108@gentoo.org \
--to=josejx@gentoo.org \
--cc=Bcm43xx-dev@lists.berlios.de \
--cc=Larry.Finger@lwfinger.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.