From: Patrick McHardy <kaber@trash.net>
To: yoshfuji@linux-ipv6.org
Cc: netdev@vger.kernel.org, netfilter-devel@lists.netfilter.org,
adobriyan@gmail.com
Subject: Re: Missing csum_fold() in ip6t_HL.c ?
Date: Mon, 12 Feb 2007 15:52:13 +0100 [thread overview]
Message-ID: <45D07F1D.7030202@trash.net> (raw)
In-Reply-To: <20070212.234721.90984848.yoshfuji@linux-ipv6.org>
YOSHIFUJI Hideaki / ^[$B5HF#1QL@^[ wrote:
> In article <20060915103755.GB5286@martell.zuzino.mipt.ru> (at Fri, 15 Sep 2006 14:37:56 +0400), Alexey Dobriyan <adobriyan@gmail.com> says:
>
>
>>It looks like "diffs" array is write-only. It also looks like ipv4
>>occurences use some csum_fold() trickery. Was is forgotten here? Should
>>"diffs" be removed?
>
>
> Since we do not have checksum in IPv6 header, we do not need to
> adjust checksum when we touch hoplimit.
>
> So, just removing it should be safe.
This already is taken care of. I noticed our listmaster didn't
approve any held messages for a couple of month and am currently
going through the backlog (Alexey's mail is quite old).
next prev parent reply other threads:[~2007-02-12 14:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 10:37 Missing csum_fold() in ip6t_HL.c ? Alexey Dobriyan
2006-09-15 20:19 ` Patrick McHardy
2007-02-12 14:47 ` YOSHIFUJI Hideaki / 吉藤英明
2007-02-12 14:52 ` Patrick McHardy [this message]
2007-02-12 15:01 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D07F1D.7030202@trash.net \
--to=kaber@trash.net \
--cc=adobriyan@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@lists.netfilter.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.