From mboxrd@z Thu Jan 1 00:00:00 1970 From: walter harms Date: Mon, 12 Feb 2007 18:12:32 +0000 Subject: Re: [KJ] need a better name for existing "FIELD_SIZE" macro sound/. Message-Id: <45D0AE10.6090705@bfs.de> List-Id: References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Robert P. J. Day wrote: > On Mon, 12 Feb 2007, walter harms wrote: > >> in my old kernel code is is only used inside the vx driver. >> IMHO it can be replaced with VX_FIELD_SIZE >> >> is is only used by functions in .h (eek) and one .c code. > > that's not quite true in the latest "git pull": > > $ grep -rwl FIELD_SIZE sound > sound/drivers/vx/vx_cmd.h > sound/drivers/vx/vx_pcm.c > sound/pci/pcxhr/pcxhr_core.h > sound/pci/pcxhr/pcxhr_hwdep.c > sound/pci/pcxhr/pcxhr_core.c > > i *could* submit a patch renaming that macro to VX_FIELD_SIZE and > PCXHR_FIELD_SIZE respectively but, if you want to look at those files > more closely, it *seems* that that field represents the same thing in > each, and i'd hate to deliberately rename a macro to two different > names for no good reason when they represent the same thing. your are right picking a later kernel code reveals it. I guess they are something like controlfield the comment in pcxhr_hwdep.c /* test 8 or 2 phys in */ seem to point to that. Just rename it, perhaps you can make emums ? the simple fact to have 2 common named macros show that the want to be renamed. The alsa-page seems to indicate the chips are related, perhaps some sound expert can comment on that ? http://www.alsa-project.org/alsa-doc/index.php?vendor=vendor-Digigram#matrix re, wh > > is there a more descriptive name that might be used that describes > what that field is *for*? > > rday > > > _______________________________________________ Kernel-janitors mailing list Kernel-janitors@lists.osdl.org https://lists.osdl.org/mailman/listinfo/kernel-janitors