From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Joe Perches <joe@perches.com>
Cc: Ben Nizette <ben.nizette@iinet.net.au>, linux-kernel@vger.kernel.org
Subject: Re: Coding style RFC: convert "for (i=0;i<ARRAY_SIZE(array);i++)" to "array_for_each(index, array)"
Date: Tue, 13 Feb 2007 18:42:48 +1100 [thread overview]
Message-ID: <45D16BF8.9090409@yahoo.com.au> (raw)
In-Reply-To: <1171352052.1528.48.camel@localhost>
Joe Perches wrote:
> On Tue, 2007-02-13 at 15:19 +1100, Nick Piggin wrote:
>
>>>> #define array_for_each(element, array) \
>>>> for (int __idx = 0; __idx < ARRAY_SIZE((array)); \
>>>> __idx++, (element) = &(array[__idx]))
>>
>>If you really wanted to introduce your loop, then please call it
>>array_for_each_idx, or something to distinguish it.
>
>
> perhaps:
>
> #define array_for_each(element, array) \
> for ((element) = (array); \
> (element) < ((array) + ARRAY_SIZE((array))); \
> (element)++)
If you're going for consistency, then shouldn't this be
array_for_each_entry()?
> #define array_for_each_index(index, array) \
> for ((index) = 0; (index) < ARRAY_SIZE((array)); (index)++)
--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com
next prev parent reply other threads:[~2007-02-13 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-12 23:47 Coding style RFC: convert "for (i=0;i<ARRAY_SIZE(array);i++)" to "array_for_each(index, array)" Joe Perches
2007-02-13 0:20 ` Ben Nizette
2007-02-13 0:47 ` Joe Perches
2007-02-13 4:19 ` Nick Piggin
2007-02-13 7:34 ` Joe Perches
2007-02-13 7:42 ` Nick Piggin [this message]
2007-02-13 10:36 ` Bernd Petrovitsch
2007-02-13 10:54 ` Nick Piggin
2007-02-13 11:07 ` Bernd Petrovitsch
2007-02-13 7:37 ` Muli Ben-Yehuda
2007-02-13 16:28 ` Randy Dunlap
2007-02-13 7:48 ` YOSHIFUJI Hideaki / 吉藤英明
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D16BF8.9090409@yahoo.com.au \
--to=nickpiggin@yahoo.com.au \
--cc=ben.nizette@iinet.net.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.