From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Jan Beulich" <jbeulich@novell.com>
Subject: RE: [PATCH] Enable K8 GART as an IOMMU
Date: Wed, 14 Feb 2007 09:21:19 +0000
Message-ID: <45D2E29F.76E4.0078.0@novell.com>
References: <1449F58C868D8D4E9C72945771150BDFD965D2@SAUSEXMB1.amd.com>
	<45D1891A.76E4.0078.0@novell.com>
	<1449F58C868D8D4E9C72945771150BDFD965F6@SAUSEXMB1.amd.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xensource.com>
In-Reply-To: <1449F58C868D8D4E9C72945771150BDFD965F6@SAUSEXMB1.amd.com>
Content-Disposition: inline
List-Unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xensource.com>
List-Help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-Subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
Sender: xen-devel-bounces@lists.xensource.com
Errors-To: xen-devel-bounces@lists.xensource.com
To: Mark Langsdorf <mark.langsdorf@amd.com>, Keir Fraser <Keir.Fraser@cl.cam.ac.uk>
Cc: xen-devel@lists.xensource.com
List-Id: xen-devel@lists.xenproject.org

>>> "Langsdorf, Mark" <mark.langsdorf@amd.com> 14.02.07 00:19 >>>
>> >--- a/linux-2.6-xen-sparse/arch/i386/mm/hypervisor.c	Fri Feb 
>> 09 10:48:41 2007 +0000
>> >+++ b/linux-2.6-xen-sparse/arch/i386/mm/hypervisor.c	Fri Feb 
>> 09 16:32:04 2007 -0600
>> >@@ -252,7 +252,7 @@ static void contiguous_bitmap_clear(
>> > }
>> > 
>> > /* Protected by balloon_lock. */
>> >-#define MAX_CONTIG_ORDER 9 /* 2MB */
>> >+#define MAX_CONTIG_ORDER 16 /* 256MB */
>> > static unsigned long discontig_frames[1<<MAX_CONTIG_ORDER];
>> > static multicall_entry_t cr_mcl[1<<MAX_CONTIG_ORDER];
>> 
>> This seems dangerous to me.
>
>We need at least 64MB of contiguous memory for the aperture.

I think this should then be established by some other means. 256Mb
(and even the minimum of 64Mb that you say you need) is, for
contiguous memory, almost as good as no limit at all. Among other
reservations I have - how do you intend to make sure the hypervisor
even has a chance of fulfilling this big a request?

But I would certainly like to know Keir's opinion here, too.

Jan