All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: Keir Fraser <keir@xensource.com>
Cc: xen-devel@lists.xensource.com
Subject: Re: [PATCH] x86/PAE partially linear page table support
Date: Thu, 15 Feb 2007 13:08:37 +0000	[thread overview]
Message-ID: <45D46965.76E4.0078.0@novell.com> (raw)
In-Reply-To: <C1F9FB59.9781%keir@xensource.com>

>That's not what I mean. Say we have two L2 tables, A and B. A[0] references
>B and B[0] references A. Even when all external references to A and B have
>gone away (i.e., there are no references from L3 tables) the type counts of
>A and B will both be non-zero because of the circular reference. This will
>prevent the pages from being freed and, ultimately, can lead to the domain
>never being destroyed.
>
>This case needs to be handled. See the code just below the largest comment
>in arch/x86/domain.c:relinquish_memory() to see how it's handled for
>top-level pagetables. Unfortunately it doesn't quite trivially generalise.

Hmm, it would seem to me that while it may not easily generalize, it at least
properly extends to the case the patch tries to address, by exchanging
PGT_base_page_table against PGT_l2_page_table. Really, in current code
this can never happen for PGT_base_page_table in PAE (or compat mode
guests), as such references aren't being established anywhere, and hence
the code should be dead for such guests.

But even for the general case - wouldn't it be possible to call
relinquish_memory() CONFIG_PAGING_LEVELS-1 times, each time lowering
the level of page tables that can be forced invalid by one?

Jan

  reply	other threads:[~2007-02-15 13:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15  9:41 [PATCH] x86/PAE partially linear page table support Jan Beulich
2007-02-15 10:25 ` Keir Fraser
2007-02-15 11:41   ` Jan Beulich
2007-02-15 11:58     ` Keir Fraser
2007-02-15 13:08       ` Jan Beulich [this message]
2007-02-15 13:24         ` Keir Fraser
2007-02-16  9:34           ` Jan Beulich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D46965.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=keir@xensource.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.