From: "Martin J. Bligh" <mbligh@mbligh.org>
To: Christoph Lameter <clameter@sgi.com>
Cc: Matt Mackall <mpm@selenic.com>,
akpm@osdl.org, Christoph Hellwig <hch@infradead.org>,
Arjan van de Ven <arjan@infradead.org>,
Nigel Cunningham <nigel@nigel.suspend2.net>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Nick Piggin <nickpiggin@yahoo.com.au>,
linux-mm@kvack.org, Rik van Riel <riel@redhat.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [PATCH 2/7] Add PageMlocked() page state bit and lru infrastructure
Date: Thu, 15 Feb 2007 07:47:01 -0800 [thread overview]
Message-ID: <45D48075.8000709@mbligh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0702150722580.10403@schroedinger.engr.sgi.com>
Christoph Lameter wrote:
> On Thu, 15 Feb 2007, Matt Mackall wrote:
>
>> Fine. But -this- comment is still incorrect. If someone were to ask
>> "what does this bit mean?" they would go the list of bit definitions
>> and leave with the -wrong- answer. The page is not necessarily
>> mlocked, it's just on the lazy mlock list.
>
> Well maybe we need to redo all the comments there in a consistent way. The
> other comments are equally sparse. Takes me a long time when try to
> figure out the role of a particular bit.
Absolutely agree, especially as they seem to be getting more and more
complicated and the rules get more and more obscure. (and we all get
old ;-))
M.
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2007-02-15 15:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 1:24 [PATCH 0/7] Move mlocked pages off the LRU and track them V1 Christoph Lameter
2007-02-15 1:24 ` [PATCH 1/7] Make try_to_unmap return a special exit code Christoph Lameter
2007-02-15 1:24 ` [PATCH 2/7] Add PageMlocked() page state bit and lru infrastructure Christoph Lameter
2007-02-15 2:09 ` Matt Mackall
2007-02-15 2:30 ` Christoph Lameter
2007-02-15 14:51 ` Matt Mackall
2007-02-15 15:24 ` Christoph Lameter
2007-02-15 15:47 ` Martin J. Bligh [this message]
2007-02-15 16:05 ` Christoph Lameter
2007-02-15 1:25 ` [PATCH 3/7] Add NR_MLOCK ZVC Christoph Lameter
2007-02-15 1:25 ` [PATCH 4/7] Logic to move mlocked pages Christoph Lameter
2007-02-15 5:33 ` Andrew Morton
2007-02-15 15:19 ` Christoph Lameter
2007-02-15 5:39 ` Andrew Morton
2007-02-15 15:21 ` Christoph Lameter
2007-02-15 1:25 ` [PATCH 5/7] Consolidate new anonymous page code paths Christoph Lameter
2007-02-15 1:25 ` [PATCH 6/7] Avoid putting new mlocked anonymous pages on LRU Christoph Lameter
2007-02-15 1:25 ` [PATCH 7/7] Opportunistically move mlocked pages off the LRU Christoph Lameter
2007-02-15 4:39 ` KAMEZAWA Hiroyuki
2007-02-15 15:15 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D48075.8000709@mbligh.org \
--to=mbligh@mbligh.org \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@osdl.org \
--cc=arjan@infradead.org \
--cc=clameter@sgi.com \
--cc=hch@infradead.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-mm@kvack.org \
--cc=mpm@selenic.com \
--cc=nickpiggin@yahoo.com.au \
--cc=nigel@nigel.suspend2.net \
--cc=riel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.