All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anssi Hannula <anssi.hannula@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: "STenyaK (Bruno Gonzalez)" <stenyak@gmail.com>,
	johann deneux <johann.deneux@gmail.com>,
	linux-input <linux-input@atrey.karlin.mff.cuni.cz>,
	Valentin Zagura <puthre@gmail.com>
Subject: Re: [PATCH] Added device to hid-ff
Date: Thu, 15 Feb 2007 21:51:07 +0200	[thread overview]
Message-ID: <45D4B9AB.70509@gmail.com> (raw)
In-Reply-To: <d120d5000702151142l5dca88f7nc71f58473fa27040@mail.gmail.com>

Dmitry Torokhov wrote:
> On 2/15/07, STenyaK (Bruno Gonzalez) <stenyak@gmail.com> wrote:
>> Sorry for not providing a proper patch, could you please also add
>>         {0x46d, 0xc294, hid_lgff_init}, // Logitech G25 wheel
>> to the list? I tested it here and that wheel is also working.
>>
> 
> OK.
> 

Hmm.. Shouldn't an entry also be added to the devices[] list in
hid-lgff.c for these devices? (and it seems one device is already
missing from there in the current kernel).

I'm not able to check right now, but I think some earlier kernels may
have defaulted to ff_joystick if no entry is present in devices[], hence
these devices working for some without the entry.
(so the alternative is to restore that behaviour)

BTW, shouldn't the PID/VID check in hid_lgff_init() do endian conversion?

-- 
Anssi Hannula

  parent reply	other threads:[~2007-02-15 19:51 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 18:56 [PATCH] Added device to hid-ff johann deneux
2007-02-15 19:17 ` Dmitry Torokhov
2007-02-15 19:40 ` STenyaK (Bruno Gonzalez)
2007-02-15 19:42   ` Dmitry Torokhov
2007-02-15 19:46     ` Dmitry Torokhov
2007-02-15 19:53       ` STenyaK (Bruno Gonzalez)
2007-02-16 10:05       ` Valentin Zagura
2007-02-16 15:20         ` STenyaK (Bruno Gonzalez)
2007-02-15 19:51     ` Anssi Hannula [this message]
2007-02-15 20:09       ` Dmitry Torokhov
2007-02-16 15:43       ` johann deneux
2007-02-16 16:03         ` Dmitry Torokhov
2007-02-16 17:28           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D4B9AB.70509@gmail.com \
    --to=anssi.hannula@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=johann.deneux@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=puthre@gmail.com \
    --cc=stenyak@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.