From: Jeff Garzik <jeff@garzik.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: Report PIO/DMA status when overriding set_mode
Date: Thu, 15 Feb 2007 17:58:42 -0500 [thread overview]
Message-ID: <45D4E5A2.5060004@garzik.org> (raw)
In-Reply-To: <20070205163344.010a9892@localhost.localdomain>
Alan wrote:
> Currently we don't report PIO/DMA information in the case we are using
> firmware mode setup by drivers, or where the value is meaningless. Even
> when we don't know the mode, or the mode is meaningless it would be nice
> to report PIO or DMA and to keep stylistic consistency. For MW/UDMA we
> can report the actual firmware set mode and we add a helper for this.
>
> This patch for now is just a proposal for comment
>
> (and while we could guess the PIO mode by playing with the command
> registers and timing them I don't think its worth it)
>
> Signed-off-by: Alan Cox <alan@redhat.com>
Looks good to me.
Dropped, since you say it's just a proposal
Jeff
prev parent reply other threads:[~2007-02-15 22:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 16:33 [PATCH] libata: Report PIO/DMA status when overriding set_mode Alan
2007-02-15 22:58 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D4E5A2.5060004@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.