From: Jeff Garzik <jeff@garzik.org>
To: Tejun Heo <htejun@gmail.com>, Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [git patches] libata updates (mostly fixes)
Date: Thu, 15 Feb 2007 18:43:58 -0500 [thread overview]
Message-ID: <45D4F03E.6040208@garzik.org> (raw)
In-Reply-To: <20070215233411.GA10782@havoc.gtf.org>
Jeff Garzik wrote:
> --- a/include/linux/ata.h
> +++ b/include/linux/ata.h
> @@ -352,7 +352,7 @@ static inline int ata_drive_40wire(const u16 *dev_id)
> {
> if (ata_id_major_version(dev_id) >= 5 && ata_id_is_sata(dev_id))
> return 0; /* SATA */
> - if (dev_id[93] & 0x4000)
> + if ((dev_id[93] & 0xE000) == 0x6000)
> return 0; /* 80 wire */
> return 1;
> }
A thought: it seems to me that the major version check should be moved
into ata_id_is_sata().
Jeff
next prev parent reply other threads:[~2007-02-15 23:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-15 23:34 [git patches] libata updates (mostly fixes) Jeff Garzik
2007-02-15 23:43 ` Jeff Garzik [this message]
2007-02-21 11:25 ` [PATCH] libata: test major version in ata_id_is_sata() Tejun Heo
2007-02-23 10:37 ` Jeff Garzik
2007-02-15 23:48 ` [git patches] libata updates (mostly fixes) Linus Torvalds
2007-02-15 23:51 ` Linus Torvalds
2007-02-16 2:09 ` Jeff Garzik
2007-02-16 12:03 ` Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D4F03E.6040208@garzik.org \
--to=jeff@garzik.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.