All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: James Bottomley <James.Bottomley@SteelEye.com>
Cc: linux-scsi <linux-scsi@vger.kernel.org>, linux-ide@vger.kernel.org
Subject: Re: BUG in libata from ata_sas_port_alloc
Date: Thu, 15 Feb 2007 15:54:41 -0800	[thread overview]
Message-ID: <45D4F2C1.4050306@us.ibm.com> (raw)
In-Reply-To: <1171575405.3412.45.camel@mulgrave.il.steeleye.com>

James Bottomley wrote:

> The problem is that memory obtained by devm_kzalloc() cannot be returned
> by kfree() ... they come from different allocation lists.  The solution
> is probably to have a corresponding ata_probe_ent_free(), I just don't
> exactly see how to tell if the object came from the devm_kzalloc or not
> (unless it gets marked).

Just a shot in the dark, but could we simply make whatever changes are
necessary to make all sas-ata LLDDs managed and then use devm_kzalloc?
Though (and I may be totally wrong here) if it's the case that
devres_head is made (or not made) to be part of a list _only_ before we
reach ata_probe_ent_alloc, we could put a similar if check into the free
function.

--D

      reply	other threads:[~2007-02-15 23:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-15 21:36 BUG in libata from ata_sas_port_alloc James Bottomley
2007-02-15 23:54 ` Darrick J. Wong [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D4F2C1.4050306@us.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=James.Bottomley@SteelEye.com \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.