All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven 'Darkman' Michels <sven@darkman.de>
To: mlmmj@mlmmj.org
Subject: Re: mlmmj maxmailsize patch
Date: Fri, 16 Feb 2007 02:45:45 +0000	[thread overview]
Message-ID: <45D51AD9.90307@darkman.de> (raw)
In-Reply-To: <6171a10dca36fac0233ac365eec3e560@mail.n0rd.dk>

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hey,

Christoph Wilke wrote:
>> - - char *maildata[4] = { "posteraddr", NULL, "maildata", NULL };
>> + char *maildata[4] = { "posteraddr", NULL, "maxmailsize", NULL };
> 
> *doi*
> Sorry for this inconvenience.

No Problem, for me as a no-coder it just takes a little longer
to understand such patches, but at least i got this fixed ;)


>> and removed two free's:
>> myfree(donemailname);
>> myfree(mailfile);
>> after the unlink and moved the free of maxmailsizestr befor the
>> unlink.
> 
> Why do you free maxmailsizestr but mailfile and donemailname
> not?
> Did I miss something?

well, simple: if i free them, it doesn't work anymore. When i
leave them as you posted them, the reject mail isn't send to the
user anymore. I get a file in queue which *should* go to the user,
but they never get sent out. After removing the two frees, it
works. Thats why i asked for a review ;)

Regards,
Sven

PS: your mailaddress was bouncing, got this fixed? ;)
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.2 (GNU/Linux)

iD8DBQFF1RrZQoCguWUBzBwRAjGVAJ9NbP4s+s2bixPesBcNVYEAVj9NiACfdvfP
YskITftEQwlX+pg1XE3NEbE’cT
-----END PGP SIGNATURE-----

  parent reply	other threads:[~2007-02-16  2:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-09 22:40 mlmmj maxmailsize patch Morten K. Poulsen
2007-01-10 10:31 ` Christoph Wilke
2007-01-22 19:27 ` Sven 'Darkman' Michels
2007-01-22 20:17 ` Sven 'Darkman' Michels
2007-01-23 11:06 ` Christoph Wilke
2007-01-24 14:29 ` Christoph Wilke
2007-02-01 22:20 ` Morten K. Poulsen
2007-02-13 18:19 ` Christoph Wilke
2007-02-14 12:42 ` Sven 'Darkman' Michels
2007-02-14 15:15 ` Sven 'Darkman' Michels
2007-02-14 22:23 ` Morten K. Poulsen
2007-02-14 23:09 ` Sven 'Darkman' Michels
2007-02-15 22:20 ` Christoph Wilke
2007-02-16  2:45 ` Sven 'Darkman' Michels [this message]
2007-02-16 19:19 ` Christoph Wilke
2007-02-16 19:26 ` Christoph Wilke
2007-02-18 11:53 ` Mads Martin Joergensen
2007-02-18 12:20 ` Sven 'Darkman' Michels
2007-02-18 21:38 ` Christoph Wilke
2007-02-20 23:01 ` Morten K. Poulsen
2007-03-03 17:43 ` Morten K. Poulsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D51AD9.90307@darkman.de \
    --to=sven@darkman.de \
    --cc=mlmmj@mlmmj.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.