From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1HI04d-0006eV-0I
	for qemu-devel@nongnu.org; Fri, 16 Feb 2007 05:12:15 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1HI04a-0006dV-Um
	for qemu-devel@nongnu.org; Fri, 16 Feb 2007 05:12:14 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1HI04a-0006dJ-JQ
	for qemu-devel@nongnu.org; Fri, 16 Feb 2007 05:12:12 -0500
Received: from seanodes.co.fr.clara.net ([212.43.220.11])
	by monty-python.gnu.org with esmtp (Exim 4.52) id 1HI04a-00089z-2T
	for qemu-devel@nongnu.org; Fri, 16 Feb 2007 05:12:12 -0500
Message-ID: <45D58378.9040509@free.fr>
Date: Fri, 16 Feb 2007 11:12:08 +0100
From: Erwan Velu <erwan.velu@free.fr>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 1/1] Making pxe working in the "NAT" mode
References: <45D38A2C.1060101@free.fr> <45D529B9.5020001@codemonkey.ws>
In-Reply-To: <45D529B9.5020001@codemonkey.ws>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Anthony Liguori <anthony@codemonkey.ws>
Cc: qemu-devel@nongnu.org

Anthony Liguori wrote:
> Hi Erwan,
>
> I really like the idea of your patch.  Of course, the hard coding is 
> not really reasonable :-)  Also, PXE is an x86-ism.  What you've 
> really done is added a mechanism to publish a BOOTP name.  We do need 
> to add a new option too as one may want to use -boot n without 
> publishing a BOOTP filename.
>
> Using your patch as a basis, I've written three patches.  The first 
> one is the tsize negotiation fix for the TFTP server.  The second adds 
> a -bootp option for specifying the location of the BOOTP image.  The 
> third changes the -tftp option to take root directory.  The end 
> result, is that now you can say:
>
> qemu -hda /tmp/a.img -boot n -tftp ~/tftpboot -bootp /pxelinux.0
>
> And you get the same results without the hard coding.  What do you think?

I just love it, you exactly did the stuff I didn't knew how to do. It 
just push a turn a simple Proof-of-concept into a "ready-to-use" feature.
Thanks a lot for you excellent work, I hope now this patch could be 
integrated upstream for allowing people to use PXE in qemu without the 
need of knowing how to configure the dhcp/tftp and bridging stuff.

One more time, thanks anthony for this patches.