From: akuster <akuster@mvista.com>
To: lkml <linux-kernel@vger.kernel.org>
Subject: [Question] detach_vmas_to_be_unmapped
Date: Fri, 16 Feb 2007 11:38:58 -1000 [thread overview]
Message-ID: <45D62472.9030202@mvista.com> (raw)
Hello,
I am a bit confused on why the vm start and end address where swapped in
arch_unmap_area and arch_unmap_area_topdown functions after the official
Avoiding mmap fragmentation ( 1363c3cd8603a913a27e2995dccbd70d5312d8e6 )
patch.
Prior to this patch arch_unmap_area() used area->vm_start and
arch_unmap_area_topdown used area->vm_end after the patch the following
change showed up.
if (mm->unmap_area == arch_unmap_area)
addr = prev ? prev->vm_start : mm->mmap_base;
else
addr = vma ? vma->vm_end : mm->mmap_base;
Using Wolfgang Wander's leakme.c test, I get the same results seen with
his original "Avoiding mmap fragmentation" patch as I do after swapping
the start & end address in the above code segment.
Is it just a typo in the official patch or am I missing the much bigger
picture?
Note: I have only run this on an Pentium4 with 1GiG memory.
TIA
Armin
reply other threads:[~2007-02-16 21:40 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D62472.9030202@mvista.com \
--to=akuster@mvista.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.