From: Jeff Garzik <jeff@garzik.org>
To: Haavard Skinnemoen <hskinnemoen@atmel.com>
Cc: netdev@vger.kernel.org, Andrew Victor <andrew@sanpeople.com>,
Patrice Vilchez <patrice.vilchez@rfo.atmel.com>,
David Brownell <dbrownell@users.sourceforge.net>
Subject: Re: [PATCH] macb: Remove inappropriate spinlocks around mii calls
Date: Sat, 17 Feb 2007 15:31:13 -0500 [thread overview]
Message-ID: <45D76611.3060801@garzik.org> (raw)
In-Reply-To: <11716379462542-git-send-email-hskinnemoen@atmel.com>
Haavard Skinnemoen wrote:
> Remove spin_lock_irqsave() around mii_ethtool_gset, mii_ethtool_sset
> and generic_mii_ioctl. These are unnecessary and harmful because
> the mii calls may call back into the mdio functions, which may sleep.
>
> Pointed out by David Brownell.
>
> Signed-off-by: Haavard Skinnemoen <hskinnemoen@atmel.com>
> ---
> drivers/net/macb.c | 24 +++---------------------
> 1 files changed, 3 insertions(+), 21 deletions(-)
applied
prev parent reply other threads:[~2007-02-17 20:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-16 14:59 [PATCH] macb: Remove inappropriate spinlocks around mii calls Haavard Skinnemoen
2007-02-17 20:31 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45D76611.3060801@garzik.org \
--to=jeff@garzik.org \
--cc=andrew@sanpeople.com \
--cc=dbrownell@users.sourceforge.net \
--cc=hskinnemoen@atmel.com \
--cc=netdev@vger.kernel.org \
--cc=patrice.vilchez@rfo.atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.