All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rene Herman <rene.herman@gmail.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: ALSA devel <alsa-devel@lists.sourceforge.net>
Subject: gusextreme: set codec_flag
Date: Sun, 18 Feb 2007 21:07:21 +0100	[thread overview]
Message-ID: <45D8B1F9.3070501@gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 448 bytes --]

Good day.

===
The gusextreme driver neglects to set the gus->codec_flag meaning 
snd_gf1_pcm_new() allocates a second "PCM Playback Volume" control, 
which makes the driver fail to load.

Signed-off-by: Rene Herman <rene.herman@gmail.com>
===

On top of isa_bus patch...

With this the driver works "fine" -- the es1688 bit is fine and the gf1 
bit has the same problems as gusclassic; I assume it's going to be the 
same solution as well.

Rene.

[-- Attachment #2: gusextreme-codec_flag.diff --]
[-- Type: text/plain, Size: 384 bytes --]

diff --git a/sound/isa/gus/gusextreme.c b/sound/isa/gus/gusextreme.c
index 74e34e6..0aeaa6c 100644
--- a/sound/isa/gus/gusextreme.c
+++ b/sound/isa/gus/gusextreme.c
@@ -283,6 +283,7 @@ static int __devinit snd_gusextreme_prob
 			"detected at 0x%lx\n", dev->bus_id, gus->gf1.port);
 		goto out;
 	}
+	gus->codec_flag = 1;
 
 	error = snd_es1688_pcm(es1688, 0, NULL);
 	if (error < 0)

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

_______________________________________________
Alsa-devel mailing list
Alsa-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/alsa-devel

             reply	other threads:[~2007-02-18 20:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-02-18 20:07 Rene Herman [this message]
2007-02-19 12:09 ` gusextreme: set codec_flag Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45D8B1F9.3070501@gmail.com \
    --to=rene.herman@gmail.com \
    --cc=alsa-devel@lists.sourceforge.net \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.