Takashi Iwai wrote:
> At Sun, 18 Feb 2007 13:58:03 +0200,
> Constantine Gavrilov wrote:
>   
>> OK. Attached.  Not changed in the bug tracking system as I could not find a way to
>> remove original patch.
>>     
>
> That doesn't matter.
>
>
>   
>> --- alsa/alsa-oss.c.orig	2007-02-18 13:29:08.000000000 +0200
>> +++ alsa/alsa-oss.c	2007-02-18 13:37:45.000000000 +0200
>>     
> (snip)
>   
>> +#define DECL_OPEN(name, callback) \
>> +int name(const char *file, int oflag, ...) \
>> +{ \
>> +	va_list args; \
>> +	mode_t mode = 0; \
>> +	int fd; \
>> +	if (!initialized) \
>> +		initialize(); \
>> +	if (oflag & O_CREAT) { \
>> +		va_start(args, oflag); \
>> +		mode = va_arg(args, mode_t); \
>> +		va_end(args); \
>> +	} \
>> +	if (is_dsp_device(file)) \
>> +		dsp_open_helper(file, oflag); \
>> +	else if (is_mixer_device(file)) \
>> +		mixer_open_helper(file, oflag); \
>>     
>
> Missing returns (or fd = ) here...
>
>
> Takashi
>
>   
You are right. Missing fd = coming from macro -> function conversion. 
Fixed patch attached.

-- 
----------------------------------------
Constantine Gavrilov
Kernel Developer
Qlusters Software Ltd
1 Azrieli Center, Tel-Aviv
Phone: +972-3-6081977
Fax:   +972-3-6081841
----------------------------------------