From: "Jan Beulich" <jbeulich@novell.com>
To: "Chuck Ebbert" <cebbert@redhat.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: mtrr range check correction
Date: Tue, 20 Feb 2007 07:47:20 +0000 [thread overview]
Message-ID: <45DAB598.76E4.0078.0@novell.com> (raw)
In-Reply-To: <45D8C620.2000009@redhat.com>
>>> Chuck Ebbert <cebbert@redhat.com> 18.02.07 22:33 >>>
>Jan Beulich wrote:
>> Whether a region is below 1Mb is determined by its start rather than
>> its end.
>>
>> This hunk got erroneously dropped from a previous patch.
>>
>> Signed-off-by: Jan Beulich <jbeulich@novell.com>
>>
>> --- linux-2.6.20/arch/i386/kernel/cpu/mtrr/generic.c 2007-02-04 19:44:54.000000000 +0100
>> +++ 2.6.20-x86-mtrr-range-check/arch/i386/kernel/cpu/mtrr/generic.c 2007-02-09 10:17:26.000000000 +0100
>> @@ -428,7 +428,7 @@ int generic_validate_add_page(unsigned l
>> }
>> }
>>
>> - if (base + size < 0x100) {
>> + if (base < 0x100) {
>> printk(KERN_WARNING "mtrr: cannot set region below 1 MiB (0x%lx000,0x%lx000)\n",
>> base, size);
>> return -EINVAL;
>>
>
>What about wraparound?
Should be caught by the subsequent checking of upper bits of first and last byte
being identical.
Jan
prev parent reply other threads:[~2007-02-20 7:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-14 7:44 [PATCH] x86: mtrr range check correction Jan Beulich
2007-02-18 21:33 ` Chuck Ebbert
2007-02-20 7:47 ` Jan Beulich [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DAB598.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=cebbert@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.