From: Mike Christie <michaelc@cs.wisc.edu>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Douglas Gilbert <dougg@torque.net>,
James Bottomley <James.Bottomley@SteelEye.com>,
Joerg Schilling <Joerg.Schilling@fokus.fraunhofer.de>,
Jens Axboe <jens.axboe@oracle.com>,
SCSI development list <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] SG: cap reserved_size values at max_sectors
Date: Tue, 20 Feb 2007 12:03:48 -0600 [thread overview]
Message-ID: <45DB3804.7020201@cs.wisc.edu> (raw)
In-Reply-To: <45DB330D.2070501@cs.wisc.edu>
Mike Christie wrote:
>
> The problem is that we assume we will get nice large segments. When
> using sg it will try to allocate multiple pages and make large segments.
> We could hit a bad case where we cannot allocate enough large segments,
> so a worst case would result in a max_segment_size of PAGE_SIZE:
>
> max_segments = min(q->max_hw_segments, q->max_phys_segments);
>
> max_xfer = min(q->max_hw_sectors * 512,
> max_segments * PAGE_SIZE);
>
> return max_xfer;
>
Oh yeah, you could also check how large the reserved buffer is already.
The estimate above does not take into account if we had already
allocated a nice large reserved buffer with large segments.
next prev parent reply other threads:[~2007-02-20 18:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-20 16:01 [PATCH] SG: cap reserved_size values at max_sectors Alan Stern
2007-02-20 17:42 ` Mike Christie
2007-02-20 18:03 ` Mike Christie [this message]
2007-02-20 18:17 ` Alan Stern
2007-02-20 19:31 ` Mike Christie
2007-02-20 19:43 ` Mike Christie
2007-02-20 19:44 ` Alan Stern
2007-04-04 18:51 ` Douglas Gilbert
-- strict thread matches above, loose matches on Subject: below --
2007-03-05 22:22 Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45DB3804.7020201@cs.wisc.edu \
--to=michaelc@cs.wisc.edu \
--cc=James.Bottomley@SteelEye.com \
--cc=Joerg.Schilling@fokus.fraunhofer.de \
--cc=dougg@torque.net \
--cc=jens.axboe@oracle.com \
--cc=linux-scsi@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.