All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Darrick J. Wong" <djwong@us.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: Tejun Heo <htejun@gmail.com>, alexisb@us.ibm.com
Subject: [PATCH 2/2]: sas_ata: Don't reset the phy in post_internal_command
Date: Thu, 22 Feb 2007 13:39:58 -0800	[thread overview]
Message-ID: <45DE0DAE.5040402@us.ibm.com> (raw)
In-Reply-To: <45C98421.7020907@gmail.com>

We don't need to reset the SAS phy in sas_ata_post_internal; all
that is necessary is to clear out the task from the SAS HA.

Signed-off-by: Darrick J. Wong <djwong@us.ibm.com>
---

 drivers/scsi/libsas/sas_ata.c |    5 -----
 1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/scsi/libsas/sas_ata.c b/drivers/scsi/libsas/sas_ata.c
index c92f4b6..d91c5ba 100644
--- a/drivers/scsi/libsas/sas_ata.c
+++ b/drivers/scsi/libsas/sas_ata.c
@@ -281,11 +281,6 @@ static void sas_ata_post_internal(struct
 
 		qc->driver_data = NULL;
 		if (task) {
-			/* Should this be a AT(API) device reset? */
-			spin_lock_irqsave(&task->task_state_lock, flags);
-			task->task_state_flags |= SAS_TASK_NEED_DEV_RESET;
-			spin_unlock_irqrestore(&task->task_state_lock, flags);
-
 			task->uldd_task = NULL;
 			__sas_task_abort(task);
 		}

  parent reply	other threads:[~2007-02-22 21:40 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070130091814.31530.23152.stgit@elm3a70.beaverton.ibm.com>
2007-01-30  9:18 ` [PATCH 01/12] sas_ata: Require CONFIG_ATA in Kconfig Darrick J. Wong
2007-01-30  9:18 ` [PATCH 02/12] sas_ata: Satisfy libata qc function locking requirements Darrick J. Wong
2007-01-30  9:18 ` [PATCH 03/12] sas_ata: sas_ata_qc_issue should return AC_ERR_* Darrick J. Wong
2007-01-30  9:18 ` [PATCH 04/12] sas_ata: ata_post_internal should abort the sas_task Darrick J. Wong
2007-02-07  7:47   ` Tejun Heo
2007-02-22 21:39     ` [PATCH 1/2] sas_ata: Rename ata_queued_cmd->lldd_task to driver_data Darrick J. Wong
2007-02-22 21:43       ` Jeff Garzik
2007-02-22 21:39     ` Darrick J. Wong [this message]
2007-01-30  9:18 ` [PATCH 05/12] sas_ata: Don't copy aic94xx's sactive to ata_port Darrick J. Wong
2007-01-30  9:18 ` [PATCH 06/12] sas_ata: Implement SATA PHY control Darrick J. Wong
2007-02-07  7:54   ` Tejun Heo
2007-01-30  9:18 ` [PATCH 07/12] libsas: Accept SAM_GOOD for ATAPI devices in sas_ata_task_done Darrick J. Wong
2007-01-30  9:18 ` [PATCH 08/12] libsas: Unknown STP devices should be reported to libata as unknown Darrick J. Wong
2007-02-07  8:20   ` Tejun Heo
2007-01-30  9:18 ` [PATCH 09/12] sas_ata: Assign sas_task to scsi_cmnd to enable EH for ATA devices Darrick J. Wong
2007-01-30  9:18 ` [PATCH 10/12] sas_ata: Implement sas_task_abort " Darrick J. Wong
2007-01-30  9:19 ` [PATCH 11/12] libsas: Provide a generic SATL registration function Darrick J. Wong
2007-01-30  9:19 ` [PATCH 12/12] sas_ata: Make this a module separate from libsas Darrick J. Wong
2007-02-03 16:03   ` James Bottomley
2007-02-04  9:06     ` Darrick J. Wong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45DE0DAE.5040402@us.ibm.com \
    --to=djwong@us.ibm.com \
    --cc=alexisb@us.ibm.com \
    --cc=htejun@gmail.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.